Skip to content

Vue component bug and docs #2061

@jackocnr

Description

@jackocnr

I've just spotted that the Vue component is checking the strictMode option to determine whether to use isValidNumber or isValidNumberPrecise, which is a bug. strictMode is a totally different feature and has nothing to do with the validation methods. Instead, it should use a dedicated prop called usePreciseValidation, like the React component.

Additionally, in the Vue component readme, it looks like a few things have been copied over from the React component readme, which I'm not sure are quite right in Vue:

  • For the "value" prop, the readme says "IntlTelInput is an uncontrolled input, and so will ignore any changes to this value." - this sounds like React language to me - can we rephrase this for Vue?
  • In the Instance Methods section, we give the example of calling ref.intlTelInput.instance.setNumber(...), but when I check in the set-number demo, we actually call ref.value?.instance?.setNumber(...)
  • We then say you can access the DOM input element via ref.intlTelInput.input - is that correct?

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions