Feature/2 dataacess repositories review (#12)

mluzyna · michalluzyna · michalluzyna · commit 5eb43dfbdeeb · 2025-04-11T16:27:47.000+02:00
* Review changes - sync with documentation

* name correction for EntitySmoke integration test

---------

Co-authored-by: MichalLuzyna &lt;michal.luzyna@capgemini.com&gt;
diff --git a/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/AppointmentRepository.java b/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/AppointmentRepository.java
@@ -77,6 +77,7 @@ SELECT CASE WHEN COUNT(a) > 0 THEN TRUE ELSE FALSE END
             JOIN a.treatment t 
             WHERE t.specialist.id = :specialistId 
             AND a.dateTime = :date
+            AND a.status <> com.capgemini.training.appointmentbooking.common.datatype.AppointmentStatus.CANCELLED
             """)
     boolean hasConflictingAppointmentBySpecialistIdAndDateTime(@Param("specialistId") Long specialistId, @Param("date") Instant date);
 
diff --git a/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/BaseJpaRepository.java b/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/BaseJpaRepository.java
@@ -2,11 +2,10 @@
 
 import jakarta.persistence.EntityManager;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.support.JpaRepositoryImplementation;
 import org.springframework.data.repository.NoRepositoryBean;
 
 @NoRepositoryBean
-public interface BaseJpaRepository<T, ID> extends JpaRepositoryImplementation<T, ID> {
+public interface BaseJpaRepository<T, ID> extends JpaRepository<T, ID> {
 
     EntityManager getEntityManager();
 
diff --git a/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/TreatmentRepository.java b/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/TreatmentRepository.java
@@ -14,7 +14,7 @@
 @Repository
 public interface TreatmentRepository extends BaseJpaRepository<TreatmentEntity, Long> {
 
-    List<TreatmentEntity> findAllByName(String name);
+    List<TreatmentEntity> findAllByNameStartingWithIgnoringCase(String name);
 
     List<TreatmentEntity> findByNameNamedQuery(String name);
 
diff --git a/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/UserRepository.java b/src/main/java/com/capgemini/training/appointmentbooking/dataaccess/repository/UserRepository.java
@@ -15,7 +15,6 @@
 
 @Repository
 public interface UserRepository extends BaseJpaRepository<UserEntity, Long> {
-
     default List<UserEntity> findByCriteria(UserCriteria criteria) {
         Objects.requireNonNull(criteria, "criteria must not be null");
 
@@ -41,4 +40,5 @@ default List<UserEntity> findByCriteria(UserCriteria criteria) {
         return entityManager.createQuery(cq).getResultList();
     }
 
+
 }
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/common/BaseDataJpaTest.java b/src/test/java/com/capgemini/training/appointmentbooking/common/BaseDataJpaTest.java
@@ -0,0 +1,11 @@
+package com.capgemini.training.appointmentbooking.common;
+
+import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
+import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
+import org.springframework.context.annotation.Import;
+import org.springframework.transaction.annotation.Transactional;
+
+@DataJpaTest
+@Import(DataaccessConfiguration.class)
+public class BaseDataJpaTest extends BaseTest{
+}
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/entity/EntitySmokeIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/entity/EntitySmokeIT.java
@@ -7,15 +7,12 @@
 
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
 
 import jakarta.persistence.EntityManager;
 import jakarta.persistence.PersistenceContext;
+import org.springframework.data.repository.config.BootstrapMode;
 
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
+@DataJpaTest(bootstrapMode = BootstrapMode.LAZY)
 public class EntitySmokeIT {
 
 	@PersistenceContext
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/AppointmentRepositoryIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/AppointmentRepositoryIT.java
@@ -1,28 +1,22 @@
 package com.capgemini.training.appointmentbooking.dataaccess.repository;
 
-import com.capgemini.training.appointmentbooking.common.BaseTest;
+import com.capgemini.training.appointmentbooking.common.BaseDataJpaTest;
 import com.capgemini.training.appointmentbooking.common.datatype.AppointmentStatus;
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.AppointmentEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.ClientEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.SpecialistEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.TreatmentEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.repository.criteria.AppointmentCriteria;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.time.Instant;
 import java.util.List;
 import java.util.Optional;
 
 
-@Transactional
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
-public class AppointmentRepositoryTestIT extends BaseTest {
+
+public class AppointmentRepositoryIT extends BaseDataJpaTest {
 
     @Inject
     private AppointmentRepository appointmentRepository;
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/ClientRepositoryIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/ClientRepositoryIT.java
@@ -1,21 +1,15 @@
 package com.capgemini.training.appointmentbooking.dataaccess.repository;
 
-import com.capgemini.training.appointmentbooking.common.BaseTest;
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
+import com.capgemini.training.appointmentbooking.common.BaseDataJpaTest;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.ClientEntity;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
 
-@Transactional
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
-public class ClientRepositoryTestIT extends BaseTest {
+
+public class ClientRepositoryIT extends BaseDataJpaTest {
 
     @Inject
     private ClientRepository clientRepository;
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/SpecialistRepositoryIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/SpecialistRepositoryIT.java
@@ -1,22 +1,15 @@
 package com.capgemini.training.appointmentbooking.dataaccess.repository;
 
-import com.capgemini.training.appointmentbooking.common.BaseTest;
+import com.capgemini.training.appointmentbooking.common.BaseDataJpaTest;
 import com.capgemini.training.appointmentbooking.common.datatype.Specialization;
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.SpecialistEntity;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
 
-@Transactional
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
-public class SpecialistRepositoryTestIT extends BaseTest {
+public class SpecialistRepositoryIT extends BaseDataJpaTest {
 
     @Inject
     private SpecialistRepository specialistRepository;
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/TreatmentRepositoryIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/TreatmentRepositoryIT.java
@@ -1,25 +1,18 @@
 package com.capgemini.training.appointmentbooking.dataaccess.repository;
 
-import com.capgemini.training.appointmentbooking.common.BaseTest;
+import com.capgemini.training.appointmentbooking.common.BaseDataJpaTest;
 import com.capgemini.training.appointmentbooking.common.datatype.Specialization;
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.SpecialistEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.TreatmentEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.repository.criteria.TreatmentCriteria;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 import java.util.Optional;
 
 
-@Transactional
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
-public class TreatmentRepositoryTestIT extends BaseTest {
+public class TreatmentRepositoryIT extends BaseDataJpaTest {
 
     @Inject
     private TreatmentRepository treatmentRepository;
@@ -30,10 +23,10 @@ public class TreatmentRepositoryTestIT extends BaseTest {
     @Test
     void shouldFindTreatmentsByName() {
         // given
-        String treatmentName = "Konsultacja dentystyczna";
+        String treatmentName = "konsUltacja de";
 
         // when
-        List<TreatmentEntity> result = treatmentRepository.findAllByName(treatmentName);
+        List<TreatmentEntity> result = treatmentRepository.findAllByNameStartingWithIgnoringCase(treatmentName);
 
         // then
         assertThat(result).hasSize(1);
diff --git a/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/UserRepositoryIT.java b/src/test/java/com/capgemini/training/appointmentbooking/dataaccess/repository/UserRepositoryIT.java
@@ -1,22 +1,15 @@
 package com.capgemini.training.appointmentbooking.dataaccess.repository;
 
-import com.capgemini.training.appointmentbooking.common.BaseTest;
-import com.capgemini.training.appointmentbooking.dataaccess.config.DataaccessConfiguration;
+import com.capgemini.training.appointmentbooking.common.BaseDataJpaTest;
 import com.capgemini.training.appointmentbooking.dataaccess.entity.UserEntity;
 import com.capgemini.training.appointmentbooking.dataaccess.repository.criteria.UserCriteria;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
-import org.springframework.context.annotation.Import;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
 
-@Transactional
-@DataJpaTest
-@Import(DataaccessConfiguration.class)
-public class UserRepositoryTestIT extends BaseTest {
+public class UserRepositoryIT extends BaseDataJpaTest {
 
     @Inject
     private UserRepository userRepository;

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`	`@Repository`
`17`	`17`	`public interface UserRepository extends BaseJpaRepository<UserEntity, Long> {`
`18`		`-`
`19`	`18`	`default List<UserEntity> findByCriteria(UserCriteria criteria) {`
`20`	`19`	`Objects.requireNonNull(criteria, "criteria must not be null");`
`21`	`20`
`@@ -41,4 +40,5 @@ default List<UserEntity> findByCriteria(UserCriteria criteria) {`
`41`	`40`	`return entityManager.createQuery(cq).getResultList();`
`42`	`41`	`}`
`43`	`42`
	`43`	`+`
`44`	`44`	`}`