From 438881ba21b569cfba0aa089cc79c3b3f52a313d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Legat?= Date: Tue, 24 Mar 2026 09:54:26 +0100 Subject: [PATCH 1/2] Fix typos in comments --- test/utils.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/utils.jl b/test/utils.jl index ae1777fb..dbccc26b 100644 --- a/test/utils.jl +++ b/test/utils.jl @@ -324,12 +324,12 @@ function qp_test( @test A * dzf ≈ -∇νf atol = ATOL rtol = RTOL end - # As a kind of integration test, we check that the scalar product is the same whether it is don at the level of + # As a kind of integration test, we check that the scalar product is the same whether it is done at the level of # 1) (dz, dλ, dν) (dλb and dνb are zero so we ignore their product (appropriate since we have not yet # implemented the getter for dνf)) dprod = dzf ⋅ dzb # ignored as it is zero : + dλf ⋅ dλb + dνf ⋅ dνb # 2) (∇z, ∇λ, ∇ν) which are the LHS of (6) and (7) (which are differentiation - # of the gradient of the laplacian with respect to z, λ and ∇ν hence the variable names) + # of the gradient of the Laplacian with respect to z, λ and ∇ν hence the variable names) if ∇λb !== nothing && !is_conic_qp ∇prod = ∇zf ⋅ ∇zb + ∇λf ⋅ ∇λb + ∇νf ⋅ ∇νb @test dprod ≈ ∇prod atol = ATOL rtol = RTOL @@ -339,7 +339,7 @@ function qp_test( # and we would still have pprod = ∇prod = dprod pprod = dQf ⋅ dQb + dqf ⋅ dqb + dGf ⋅ dGb + dhf ⋅ dhb + dAf ⋅ dAb + dbf ⋅ dbb - @test pprod ≈ pprod atol = ATOL rtol = RTOL + @test pprod ≈ dprod atol = ATOL rtol = RTOL return end From 526aba2fb4a7998d803d7e58d08c46c60e3a05e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Legat?= Date: Tue, 24 Mar 2026 10:46:33 +0100 Subject: [PATCH 2/2] Apply suggestion from @blegat --- test/utils.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/utils.jl b/test/utils.jl index dbccc26b..0f103222 100644 --- a/test/utils.jl +++ b/test/utils.jl @@ -339,7 +339,7 @@ function qp_test( # and we would still have pprod = ∇prod = dprod pprod = dQf ⋅ dQb + dqf ⋅ dqb + dGf ⋅ dGb + dhf ⋅ dhb + dAf ⋅ dAb + dbf ⋅ dbb - @test pprod ≈ dprod atol = ATOL rtol = RTOL + @test pprod ≈ pprod atol = ATOL rtol = RTOL return end