Open
Conversation
odow
commented
Mar 13, 2026
odow
commented
Mar 13, 2026
odow
commented
Mar 13, 2026
This was referenced Mar 17, 2026
odow
changed the title
Member
Author
|
I now have maintain access to CliqueTrees (thanks @samuelsonric). So the question remains: should we use only CliqueTrees? Or should we also include LDLFactorizations? Using only CliqueTrees would be simpler in the long term. |
Member
|
I vote for using only CliqueTrees unless we have a specific reason to add LDLFactorizations. Being a bit faster in some cases isn't a sufficient reason unless this code path is shown to be a bottleneck. |
Member
Author
|
Okay let me remove the LDL stuff. We can always add it back later. |
odow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #2965
I'm really not sure about this. This is about the 10th thing I have prototyped locally. It's just a mess. And I don't know how to test the situation where the packages aren't loaded without something brittle like "run this file before running this one".