Add copy error to clipboard button
#382
Open
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cc @balajialg |
|
@jnywong That's great, Thank you! |
yuvipanda
reviewed
Dec 5, 2025
| const button = this.copyError; | ||
| button.onclick = async () => { | ||
| try { | ||
| await navigator.clipboard.writeText(errorText); |
Contributor
There was a problem hiding this comment.
Thinking about what other thing would be useful, can you also copy the nbgitpuller URL itself? that contains important and helpful info about the repo and branch that I think help a lot. But let's just copy the url - base_url (so just /git-sync?query-params) so we don't automatically include the username here, as that could be PII.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to copy to clipboard the error log from the terminal output.
nbgitpuller-copy-error.mp4
Closes 2i2c-org/infrastructure#7083
More specific and user-friendly error responses for the top 3 failure modes to follow in a separate PR (as part of 2i2c-org/infrastructure#7085), which will rely less on the terminal window/traceback logs.