Skip to content

QueryFilter::make() should return static instead of self #22

@kblais

Description

@kblais

Static analysis throws an error with this code :

class JobFilter extends QueryFilter
{
    ...
}

class JobController
{
    protected JobFilter $filter;

    public function index(Request $request) {
        $this->jobFilter = JobFilter::make(['foo' => $request->input('foo')]);
    }
}

Error from PHPStan : "Property JobController::$filter (JobFilter) does not accept Kblais\QueryFilter\QueryFilter"

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions