Describe the issue
The annotation key format string for bootstrap completion tracking is
duplicated in two separate functions in
internal/controller/node_controller.go:
- Line 327 in
isBootstrapCompleted
- Line 335 in
markBootstrapCompleted
Both use:
fmt.Sprintf("readiness.k8s.io/bootstrap-completed-%s", ruleName)
If one is updated but not the other, it causes a silent bug where
bootstrap completion is never detected.
Expected behavior
Extract into a single helper function:
func bootstrapAnnotationKey(ruleName string) string {
return fmt.Sprintf("readiness.k8s.io/bootstrap-completed-%s", ruleName)
}
File
internal/controller/node_controller.go lines 327, 335
Are you able to fix this issue?
Yes (I will propose a PR)
Describe the issue
The annotation key format string for bootstrap completion tracking is
duplicated in two separate functions in
internal/controller/node_controller.go:isBootstrapCompletedmarkBootstrapCompletedBoth use:
If one is updated but not the other, it causes a silent bug where
bootstrap completion is never detected.
Expected behavior
Extract into a single helper function:
File
internal/controller/node_controller.golines 327, 335Are you able to fix this issue?
Yes (I will propose a PR)