build: add spotless, checkstyle, and enforcer plugin configuration#23
Open
wombatu-kun wants to merge 1 commit into
Open
build: add spotless, checkstyle, and enforcer plugin configuration#23wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
wombatu-kun
force-pushed
the
build/code-style-setup
branch
from
fd50c7c to
72001b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkstyle.xmlported fromlance-spark..editorconfigfor cross-IDE consistency (UTF-8, LF, 4-space Java,2-space XML/YAML, tab Makefile,
max_line_length = 100).spotless-maven-plugin2.43.0 with google-java-format 1.19.2(GOOGLE style),
importOrder = org.apache.flink,,javax,java,#,removeUnusedImports, and the short Apache 2.0 license header.Invoked explicitly:
mvn spotless:check/mvn spotless:apply.maven-checkstyle-plugin3.3.1 withconfigLocation=checkstyle.xml,failsOnError=true,violationSeverity=warning. Invoked explicitly:mvn checkstyle:check.maven-enforcer-plugin3.4.1 withrequireMavenVersion 3.6.3andbanDuplicatePomDependencyVersions, bound to thevalidatephase.Spotless and Checkstyle are intentionally not bound to a build phase
in this PR. They will be wired into the
validatephase in the follow-upPR
chore: apply initial spotless formatting, which also runsmvn spotless:applyagainst the existing 31.javafiles. Splitting thework this way keeps the configuration PR small and reviewable, and the
formatting PR mechanical and trivially reviewable.