Skip to content

update kokkos kernels linalg call after kokkos kernels became more strict #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yurlungur merged 3 commits into from
Feb 3, 2026
Merged

update kokkos kernels linalg call after kokkos kernels became more strict #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29295fc
test
rbberger Jan 28, 2026
15bd3fd
Changelog
jonahm-LANL Jan 30, 2026
7baf22e
Update CHANGELOG.md
Yurlungur Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [[PR601]](https://github.com/lanl/singularity-eos/pull/601) Make Serialize() return a smart pointer

### Infrastructure (changes irrelevant to downstream codes)
- [[PR604]](https://github.com/lanl/singularity-eos/pull/604) Update kokkos kernels linalg call after kokkos kernels became more strict

### Removed (removing behavior/API/varaibles/...)

Expand Down
6 changes: 3 additions & 3 deletions singularity-eos/closure/mixed_cell_models.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#ifdef SINGULARITY_USE_KOKKOSKERNELS
#include <KokkosBatched_ApplyQ_Decl.hpp>
#include <KokkosBatched_QR_Decl.hpp>
#include <KokkosBatched_Trsv_Decl.hpp>
#include <KokkosBatched_Trsm_Decl.hpp>
#else
#include <Eigen/Dense>
#endif // SINGULARITY_USE_KOKKOSKERNELS
Expand Down Expand Up @@ -170,12 +170,12 @@ bool solve_Ax_b_wscr(const std::size_t n, Real *a, Real *b, Real *scr) {
using ApQ_alg = KokkosBatched::Algo::ApplyQ::Unblocked;
using UP = KokkosBatched::Uplo::Upper;
using NonU = KokkosBatched::Diag::NonUnit;
using Tr_alg = KokkosBatched::Algo::Trsv::Unblocked;
using Tr_alg = KokkosBatched::Algo::Trsm::Unblocked;
// aliases for solver structs ('invoke' member of the struct is the
// actual function call)
using QR_factor = KokkosBatched::SerialQR<QR_alg>;
using ApplyQ_transpose = KokkosBatched::SerialApplyQ<Lft, Trs, ApQ_alg>;
using InvertR = KokkosBatched::SerialTrsv<UP, nTrs, NonU, Tr_alg>;
using InvertR = KokkosBatched::SerialTrsm<Lft, UP, nTrs, NonU, Tr_alg>;
// view of matrix
Kokkos::View<Real **, Lrgt, Unmgd> A(a, n, n);
// view of RHS
Expand Down