Skip to content

Commit b6ec20c

Browse files
authored
feat: not set is_unique by default (#434)
2 parents 1ff5067 + 7cc7919 commit b6ec20c

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

leancloud/conversation.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Conversation(Object):
2525
:param is_transient: 是否暂态会话
2626
:param is_unique: 是否重用成员相同的会话(暂停会话不支持此参数)
2727
"""
28-
def __init__(self, name=None, is_system=False, is_transient=False, is_unique=True):
28+
def __init__(self, name=None, is_system=False, is_transient=False, is_unique=None):
2929
super(Conversation, self).__init__()
3030
if name:
3131
self.set('name', name)
@@ -35,7 +35,8 @@ def __init__(self, name=None, is_system=False, is_transient=False, is_unique=Tru
3535
if is_transient:
3636
self.set('tr', True)
3737
else:
38-
self.set('unique', is_unique)
38+
if is_unique is not None:
39+
self.set('unique', is_unique)
3940

4041
@property
4142
def name(self):

tests/test_conversation.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,30 @@ def test_create_conversation():
2727
conv = Conversation('testConversation')
2828
conv.save()
2929
assert conv.id
30-
assert conv.is_unique
30+
assert not conv.is_unique
3131
assert not conv.is_system
3232
assert not conv.is_transient
3333
conv.destroy()
3434

35-
conv = Conversation('testConversation', is_system=True, is_transient=True)
35+
conv = Conversation('testConversation', is_system=True, is_transient=True, is_unique=True)
3636
conv.save()
3737
assert conv.id
3838
assert conv.is_system
3939
assert conv.is_transient
4040
assert not conv.is_unique
4141
conv.destroy()
4242

43+
conv = Conversation('testConversation', is_unique=True)
44+
conv.save()
45+
assert conv.id
46+
assert conv.is_unique
47+
conv.destroy()
48+
49+
conv = Conversation('testConversation', is_unique=False)
50+
conv.save()
51+
assert conv.id
52+
assert not conv.is_unique
53+
conv.destroy()
4354

4455
def test_members():
4556
conv = Conversation('test')

0 commit comments

Comments
 (0)