fix(quic): Improve Listener Socket Selection when Dialing #6224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation now mirrors the TCP transport's approach by maintaining a centralized registry of listening addresses. When dialing, the transport queries this registry to find a suitable listener socket that matches the destination's IP version and loopback status.
Related: #4259
Notes & open questions
It could be optimized further, where we could query the OS routing table to determine the optimal source IP for reaching a destination, then find a listener bound to that IP. This provides the most accurate routing decisions because the OS kernel knows all routes, VPNs, policies, etc.
Change checklist