Skip to content

chore: update changelog to 1.2.48#339

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-1.2.48
Mar 5, 2026
Merged

chore: update changelog to 1.2.48#339
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-1.2.48

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Mar 5, 2026

更新说明

自动更新 changelog 到版本 1.2.48

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 1.2.48
  • 目标分支: master

Summary by Sourcery

Documentation:

  • Document release 1.2.48 in debian/changelog.

update changelog to 1.2.48

Log: update changelog to 1.2.48
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian package changelog to reflect a new release version 1.2.48 targeting master, without any code or behavior changes.

File-Level Changes

Change Details Files
Bump Debian package changelog entry to version 1.2.48.
  • Add or update the latest changelog stanza to version 1.2.48.
  • Record that this is an automated changelog update.
  • Ensure the changelog is formatted correctly for Debian packaging tools (dch).
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

TAG Bot

TAG: 1.2.48
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 内容主要记录了软件包 dde-application-manager 的版本变更信息。经过审查,我发现了几个需要改进的地方,涉及语法规范、逻辑正确性和数据准确性。

以下是详细的审查意见:

1. 数据准确性:日期错误(严重)

  • 问题:新版本条目中的日期写的是 2026 年(Thu, 05 Mar 2026)。
  • 分析:除非这是一个为了测试未来时间旅行功能而特意提交的代码,否则这明显是一个笔误。当前时间远早于 2026 年,错误的年份会导致 dpkg-parsechangelog 等工具在处理时间戳或生成发布包时产生混乱,甚至影响版本排序。
  • 建议:请将年份修正为当前的正确年份(例如 20242025)。

2. 语法与格式:Debian 维护者字段格式(中等)

  • 问题:维护者字段格式为 -- zhangkun <zhangkun2@uniontech.com>
  • 分析:虽然这在很多构建系统中能工作,但根据 Debian 政策,维护者字段最好包含全名。仅使用用户名 zhangkun 可能不符合部分严格的发行版规范,且显得不够正式。
  • 建议:建议补充完整的中文或英文姓名,例如 -- Zhang Kun <zhangkun2@uniontech.com>

3. 代码质量与规范:提交信息风格(轻微)

  • 问题:变更日志中使用了 feat:fix: 前缀。
  • 分析:这是典型的 Conventional Commits 规范(常用于 Git Commit Message),虽然清晰易读,但 debian/changelog 有其传统的描述习惯。Debian 社区通常更习惯直接用动词开头描述变更(如 "Add ..." 或 "Fix ..."),而不是显式标记类型。
  • 建议
    • 如果项目内部统一要求使用这种风格,则保持现状。
    • 如果是为了遵循上游 Debian 标准,建议修改为更传统的写法,例如:
      • feat: add DesktopSourcePath... -> Add DesktopSourcePath property to Application DBus interface.
      • fix: use state machine... -> Use state machine for argument parsing and support single quotes.

4. 逻辑与内容:变更描述清晰度(轻微)

  • 问题fix: use state machine for argument parsing and support single quotes 被分成了两行。
  • 分析:在 debian/changelog 中,每一行变更记录前通常有一个空格或两个空格的缩进,后续换行通常也是对齐的。这里的 diff 显示第二行 quotes 前面有缩进,这是符合格式的。但从逻辑上讲,"支持单引号" 是引入状态机解析参数的直接结果或目的。
  • 建议:目前的写法是可以接受的。如果为了更严谨,可以明确指出这是为了修复什么具体的 bug(例如:修复了包含单引号的参数无法正确解析的问题)。

总结与修改建议

建议将 debian/changelog 的该条目修改如下(假设年份修正为 2024,并优化了描述风格):

+dde-application-manager (1.2.48) unstable; urgency=medium
+
+  * Add DesktopSourcePath property to Application DBus interface.
+  * Use state machine for argument parsing to support single quotes correctly.
+
+ -- Zhang Kun <zhangkun2@uniontech.com>  Thu, 05 Mar 2024 20:44:04 +0800

核心修改点:

  1. 2026 改为 2024
  2. 去掉了 feat:/fix: 前缀,改为首字母大写的动词开头(可选,视项目规范而定)。
  3. 补充了维护者的全名(可选,视公司规范而定)。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Mar 5, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit b7841e3 into linuxdeepin:master Mar 5, 2026
17 of 19 checks passed
@deepin-bot
Copy link

deepin-bot bot commented Mar 5, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 1.2.48
  • Tag SHA: 4268898dc673d402c6b83f3a4fec747925cec4ea
  • Commit SHA: 298fb992f2d4b541a92de26ac3226f905664f9b0
  • Tag Message:
    Release dde-application-manager 1.2.48
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants