Fix External Method Not Found (#228)

Author: rcosta358

liquidjava-verifier/src/main/java/liquidjava/diagnostics/warnings/ExternalMethodNotFoundWarning.java

@@ -9,20 +9,20 @@
  */
 public class ExternalMethodNotFoundWarning extends LJWarning {
 
-    private final String methodName;
+    private final String signature;
     private final String className;
     private final String[] overloads;
 
-    public ExternalMethodNotFoundWarning(SourcePosition position, String message, String methodName, String className,
+    public ExternalMethodNotFoundWarning(SourcePosition position, String message, String signature, String className,
             String[] overloads) {
         super(message, position);
-        this.methodName = methodName;
+        this.signature = signature;
         this.className = className;
         this.overloads = overloads;
     }
 
-    public String getMethodName() {
-        return methodName;
+    public String getSignature() {
+        return signature;
     }
 
     public String getClassName() {

liquidjava-verifier/src/main/java/liquidjava/processor/refinement_checker/ExternalRefinementTypeChecker.java

@@ -72,19 +72,19 @@ public <R> void visitCtMethod(CtMethod<R> method) {
         boolean isConstructor = method.getSimpleName().equals(targetType.getSimpleName());
         if (isConstructor) {
             if (!constructorExists(targetType, method)) {
-                String message = String.format("Could not find constructor '%s' for '%s'", method.getSignature(),
-                        prefix);
+                String signature = method.getSignature();
+                String message = String.format("Could not find constructor '%s' for '%s'", signature, prefix);
                 String[] overloads = getOverloads(targetType, method);
-                diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, method.getSignature(),
+                diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, signature,
                         prefix, overloads));
             }
         } else {
             if (!methodExists(targetType, method)) {
-                String message = String.format("Could not find method '%s %s' for '%s'",
-                        method.getType().getSimpleName(), method.getSignature(), prefix);
+                String signature = String.format("%s %s", method.getType().getSimpleName(), method.getSignature());
+                String message = String.format("Could not find method '%s' for '%s'", signature, prefix);
                 String[] overloads = getOverloads(targetType, method);
-                diagnostics.add(new ExternalMethodNotFoundWarning(method.getPosition(), message, method.getSignature(),
-                        prefix, overloads));
+                diagnostics.add(
+                        new ExternalMethodNotFoundWarning(method.getPosition(), message, signature, prefix, overloads));
                 return;
             }
         }