Skip to content

Fixed the WrenMethod highlighting to handle static fields (and index fields) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
avivbeeri wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed the WrenMethod highlighting to handle static fields (and index fields) #10

avivbeeri wants to merge 3 commits into from

Conversation

@avivbeeri
Copy link
Contributor

@avivbeeri avivbeeri commented Oct 15, 2021

I realised that if you had a method like static [id] { _id } then the static part would not be highlighted correctly.

This fixes that.

@avivbeeri
Copy link
Contributor Author

avivbeeri commented Oct 16, 2021

Although, this fix causes some other issues:
_someVariable = {} is no longer highlighted, as an example.

So I'll go back to the drawing board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@avivbeeri