Skip to content

Commit fe9fe58

Browse files
committed
Refactor Android and iOS build workflows to remove architecture matrix and simplify job names
1 parent c286cca commit fe9fe58

2 files changed

Lines changed: 2 additions & 18 deletions

File tree

.github/workflows/android-build.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,8 @@ concurrency:
3636

3737
jobs:
3838
build:
39-
name: Build Android Example App (${{ matrix.arch }})
39+
name: Build Android Example App
4040
runs-on: ubuntu-latest
41-
strategy:
42-
fail-fast: false
43-
matrix:
44-
arch: [new, old]
4541
steps:
4642
- uses: actions/checkout@v4
4743
- uses: actions/setup-node@v4
@@ -54,10 +50,6 @@ jobs:
5450
- name: Generate Nitro bindings
5551
run: yarn codegen
5652

57-
- name: Disable new architecture in gradle.properties
58-
if: matrix.arch == 'old'
59-
run: sed -i "s/newArchEnabled=true/newArchEnabled=false/g" example/android/gradle.properties
60-
6153
- name: Setup JDK 17
6254
uses: actions/setup-java@v5
6355
with:

.github/workflows/ios-build.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,8 @@ concurrency:
4747

4848
jobs:
4949
build:
50-
name: Build iOS Example App (${{ matrix.arch }})
50+
name: Build iOS Example App
5151
runs-on: macOS-15
52-
strategy:
53-
fail-fast: false
54-
matrix:
55-
arch: [new, old]
5652
steps:
5753
- uses: actions/checkout@v4
5854
- uses: actions/setup-node@v4
@@ -69,10 +65,6 @@ jobs:
6965
- name: Generate Nitro bindings
7066
run: yarn codegen
7167

72-
- name: Disable new architecture in Podfile
73-
if: matrix.arch == 'old'
74-
run: sed -i "" "s/ENV\['RCT_NEW_ARCH_ENABLED'\] = '1'/ENV['RCT_NEW_ARCH_ENABLED'] = '0'/g" example/ios/Podfile
75-
7668
- name: Setup Ruby (bundle)
7769
uses: ruby/setup-ruby@v1
7870
with:

0 commit comments

Comments
 (0)