AC-3483:: SVC false-positive: modifying system.xml file from another module

Author: cod62627

src/Analyzer/SystemXml/Analyzer.php

@@ -164,7 +164,7 @@ private function getBaseDir($filePath)
      * @param string $excludeFile The file to exclude from the search.
      * @return array An array of paths to system.xml files, excluding the specified file.
      */
-    private function getSystemXmlFiles($magentoBaseDir, $excludeFile = null)
+    private function getSystemXmlFiles($magentoBaseDir, $excludeFile = null): array
     {
         $systemXmlFiles = [];
         $directoryToSearch = [
@@ -195,7 +195,7 @@ private function getSystemXmlFiles($magentoBaseDir, $excludeFile = null)
      * @param $nodePath
      * @return array|null
      */
-    private function extractSectionGroupField($nodePath)
+    private function extractSectionGroupField($nodePath): ?array
     {
         $parts = explode('/', $nodePath);
 
@@ -218,7 +218,7 @@ private function extractSectionGroupField($nodePath)
      * @return array
      * @throws \ReflectionException
      */
-    private function getNodeData($node)
+    private function getNodeData($node): array
     {
         $data = [];
 
@@ -406,7 +406,6 @@ private function isDuplicatedFieldInXml(
                     [
                         'status' => 'duplicate',
                         'field'  => $fieldId
-
                     ]
                 ];
             }