AC-3483:: SVC false-positive: modifying system.xml file from another module

Author: cod62627

src/Analyzer/SystemXml/Analyzer.php

@@ -114,6 +114,7 @@ public function analyze($registryBefore, $registryAfter)
 
                     // Call function to check if this field is duplicated in other system.xml files
                     $isDuplicated = $this->isDuplicatedFieldInXml($baseDir, $sectionId, $groupId, $fieldId, $afterFile);
+
                     foreach ($isDuplicated as $isDuplicatedItem) {
                         if ($isDuplicatedItem['status'] === 'duplicate') {
                             $this->reportDuplicateNodes($afterFile, [$nodeId => $node ]);
@@ -197,7 +198,6 @@ private function extractSectionGroupField($nodePath)
         $groupId = $parts[1];
         $fieldId = $parts[2];
 
-
         return [$sectionId, $groupId, $fieldId];
     }
 
@@ -307,7 +307,6 @@ private function reportDuplicateNodes(string $file, array $nodes)
                 case $node instanceof Field:
                     $this->report->add('system', new DuplicateFieldAdded($file, $node->getPath()));
                     break;
-                default:
             }
         }
     }
@@ -364,11 +363,14 @@ private function isDuplicatedFieldInXml(?string $baseDir, string $sectionId, str
     {
         $hasDuplicate = false;
 
+        $result = [
+            'status' => 'minor',
+            'field'  => $fieldId
+        ];
+
         if ($baseDir) {
             $systemXmlFiles = $this->getSystemXmlFiles($baseDir, $afterFile);
 
-            $result = [];
-
             foreach ($systemXmlFiles as $systemXmlFile) {
                 $xmlContent = file_get_contents($systemXmlFile);
                 try {
@@ -385,17 +387,15 @@ private function isDuplicatedFieldInXml(?string $baseDir, string $sectionId, str
                 }
             }
             if ($hasDuplicate) {
-                $result[] = [
-                    'status' => 'duplicate',
-                    'field'  => $fieldId
-                ];
-            } else {
-                $result[] = [
-                    'status' => 'minor',
-                    'field'  => $fieldId
+                return [
+                    [
+                        'status' => 'duplicate',
+                        'field'  => $fieldId
+
+                    ]
                 ];
             }
         }
-        return $result;
+        return [$result];
     }
 }