SVC false-positive: modifying system.xml file from another module

Author: glo71317

src/Analyzer/SystemXml/Analyzer.php

@@ -144,7 +144,7 @@ public function analyze($registryBefore, $registryAfter)
      * @param string $filePath
      * @return string|null
      */
-    private function getBaseDir($filePath)
+    private function getBaseDir($filePath): ?string
     {
         $currentDir = dirname($filePath);
         while ($currentDir !== '/' && $currentDir !== false) {
@@ -327,8 +327,9 @@ private function reportDuplicateNodes(string $file, array $nodes): void
      *
      * @param array $modules
      * @param XmlRegistry $registryBefore
+     * @return void
      */
-    private function reportRemovedFiles(array $modules, XmlRegistry $registryBefore)
+    private function reportRemovedFiles(array $modules, XmlRegistry $registryBefore): void
     {
         foreach ($modules as $module) {
             $beforeFile = $registryBefore->mapping[XmlRegistry::NODES_KEY][$module];
@@ -341,8 +342,9 @@ private function reportRemovedFiles(array $modules, XmlRegistry $registryBefore)
      *
      * @param string $file
      * @param NodeInterface[] $nodes
+     * @return void
      */
-    private function reportRemovedNodes(string $file, array $nodes)
+    private function reportRemovedNodes(string $file, array $nodes): void
     {
         foreach ($nodes as $node) {
             switch (true) {
@@ -361,15 +363,14 @@ private function reportRemovedNodes(string $file, array $nodes)
         }
     }
 
-    /**
-     * @param string|null $baseDir
-     * @param string $sectionId
-     * @param string $groupId
-     * @param string $fieldId
-     * @param string $afterFile
-     * @return array
-     * @throws \Exception
-     */
+  /**
+   * @param string|null $baseDir
+   * @param string $sectionId
+   * @param string $groupId
+   * @param string|null $fieldId
+   * @param string $afterFile
+   * @return array
+   */
     private function isDuplicatedFieldInXml(
         ?string $baseDir,
         string $sectionId,