Skip to content

activator removal phase 5.4: Go SDK + Go consumers — propagate status variant renames #3620

@elitegreg

Description

@elitegreg

Part of the activator removal effort — see tracker #3607.

Phase / PR: Phase 5, PR 5.4

Gate: Phase 5.1 merged.

Goal

Mirror the Rust *Deprecated rename in the Go SDK and fix every Go consumer.

Files

  • smartcontract/sdk/go/serviceability/state.go — rename Go constants:
    • UserStatusPendingUserStatusPendingDeprecated
    • UserStatusRejectedUserStatusRejectedDeprecated
    • UserStatusPendingBanUserStatusPendingBanDeprecated (if confirmed activator-only by PR 5.1 audit)
    • DeviceStatusPending, DeviceStatusRejected
    • LinkStatusPending (subject to the controller sentinel decision in PR 5.1), LinkStatusRejected
    • Equivalent MulticastGroupStatus, LocationStatusPending, ExchangeStatusPending constants.
    • Preserve numeric values.
  • smartcontract/sdk/go/serviceability/state_test.go, smartcontract/sdk/go/serviceability/influx_test.go, smartcontract/sdk/go/serviceability/client_test.go — fix references.
  • client/doublezerod/internal/manager/manager.go and reconciler_test.go — fix references; apply the test handling rule from Phase 4 (no net-loss of coverage).
  • controlplane/monitor/internal/serviceability/audits.go and events_test.go — fix references.
  • controlplane/controller/internal/controller/server.go, models.go, server_test.go, render_test.go — fix references; if the PR 5.1 audit chose option (b) for the LinkStatusPending sentinel, update the controller to use the new sentinel value.
  • controlplane/device-health-oracle/internal/worker/criteria.go and its tests — fix references.
  • controlplane/telemetry/internal/{geoprobe,bgpstatus,telemetry}/ — fix references.
  • e2e/*_test.go — fix references.

Acceptance

  • make go-build and make go-test pass.
  • grep -rn "UserStatusPending\b\|DeviceStatusPending\b\|LinkStatusPending\b" returns only the renamed constant uses (and, if option (a) was chosen for the controller sentinel, the unrenamed LinkStatusPending continues to appear).
  • Net coverage of legacy/Pending/Rejected behavior is preserved or migrated.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions