added redirect standart input + kill process if something goes wrong so it wont loop test execution

Author: Serhiiiiko

ClaudeCodeSharpSDK.Tests/Integration/ClaudeCliSmokeTests.cs

@@ -37,10 +37,12 @@ public class ClaudeCliSmokeTests
     private const string FailedToResolveExecutablePathMessage = "Failed to resolve Claude Code CLI path.";
     private const string CouldNotLocateRepositoryRootMessage = "Could not locate repository root from test execution directory.";
     private const string StartProcessFailedMessagePrefix = "Failed to start Claude Code CLI at";
+    private const string ClaudeCodeNestingEnvironmentVariable = "CLAUDECODE";
     private const string Space = " ";
     private const string MessageQuote = "'";
     private const string MessageSuffix = ".";
     private static readonly string[] StandardLineSeparators = [Environment.NewLine, NewLine, CarriageReturn];
+    private static readonly TimeSpan TestTimeout = TimeSpan.FromSeconds(30);
 
     [Test]
     public async Task ClaudeCli_Smoke_FindExecutablePath_ResolvesExistingBinary()
@@ -52,7 +54,8 @@ public async Task ClaudeCli_Smoke_FindExecutablePath_ResolvesExistingBinary()
     [Test]
     public async Task ClaudeCli_Smoke_VersionCommand_ReturnsClaudeCodeVersion()
     {
-        var result = await RunClaudeAsync(ResolveExecutablePath(), null, VersionFlag);
+        using var timeoutCts = new CancellationTokenSource(TestTimeout);
+        var result = await RunClaudeAsync(ResolveExecutablePath(), null, timeoutCts.Token, VersionFlag);
 
         await Assert.That(result.ExitCode).IsEqualTo(0);
         await Assert.That(string.Concat(result.StandardOutput, result.StandardError))
@@ -62,7 +65,8 @@ await Assert.That(string.Concat(result.StandardOutput, result.StandardError))
     [Test]
     public async Task ClaudeCli_Smoke_HelpCommand_DescribesStreamJsonOutput()
     {
-        var result = await RunClaudeAsync(ResolveExecutablePath(), null, HelpFlag);
+        using var timeoutCts = new CancellationTokenSource(TestTimeout);
+        var result = await RunClaudeAsync(ResolveExecutablePath(), null, timeoutCts.Token, HelpFlag);
 
         await Assert.That(result.ExitCode).IsEqualTo(0);
         await Assert.That(string.Concat(result.StandardOutput, result.StandardError))
@@ -73,12 +77,14 @@ await Assert.That(string.Concat(result.StandardOutput, result.StandardError))
     public async Task ClaudeCli_Smoke_PrintModeWithoutAuth_EmitsInitAndLoginGuidance()
     {
         var sandboxDirectory = CreateSandboxDirectory();
+        using var timeoutCts = new CancellationTokenSource(TestTimeout);
 
         try
         {
             var result = await RunClaudeAsync(
                 ResolveExecutablePath(),
                 CreateUnauthenticatedEnvironmentOverrides(sandboxDirectory),
+                timeoutCts.Token,
                 PrintFlag,
                 OutputFormatFlag,
                 StreamJsonFormat,
@@ -190,10 +196,12 @@ private static string ResolveRepositoryRootPath()
     private static async Task<ClaudeProcessResult> RunClaudeAsync(
         string executablePath,
         IReadOnlyDictionary<string, string>? environmentOverrides,
+        CancellationToken cancellationToken = default,
         params string[] arguments)
     {
         var startInfo = new ProcessStartInfo(executablePath)
         {
+            RedirectStandardInput = true,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
             UseShellExecute = false,
@@ -205,6 +213,8 @@ private static async Task<ClaudeProcessResult> RunClaudeAsync(
             startInfo.ArgumentList.Add(argument);
         }
 
+        startInfo.Environment.Remove(ClaudeCodeNestingEnvironmentVariable);
+
         if (environmentOverrides is not null)
         {
             foreach (var (key, value) in environmentOverrides)
@@ -226,10 +236,27 @@ private static async Task<ClaudeProcessResult> RunClaudeAsync(
                     MessageSuffix));
         }
 
-        var standardOutputTask = process.StandardOutput.ReadToEndAsync();
-        var standardErrorTask = process.StandardError.ReadToEndAsync();
+        process.StandardInput.Close();
+
+        using var registration = cancellationToken.Register(() =>
+        {
+            try
+            {
+                if (!process.HasExited)
+                {
+                    process.Kill(entireProcessTree: true);
+                }
+            }
+            catch (InvalidOperationException)
+            {
+                // Process already exited between check and kill — safe to ignore.
+            }
+        });
+
+        var standardOutputTask = process.StandardOutput.ReadToEndAsync(cancellationToken);
+        var standardErrorTask = process.StandardError.ReadToEndAsync(cancellationToken);
 
-        await process.WaitForExitAsync();
+        await process.WaitForExitAsync(cancellationToken);
 
         return new ClaudeProcessResult(
             process.ExitCode,

ClaudeCodeSharpSDK.Tests/Integration/RealClaudeIntegrationTests.cs

@@ -8,6 +8,7 @@ namespace ManagedCode.ClaudeCodeSharpSDK.Tests.Integration;
 public class RealClaudeIntegrationTests
 {
     private const string ReplyWithOkOnlyPrompt = "Reply with OK only.";
+    private static readonly TimeSpan TestTimeout = TimeSpan.FromSeconds(60);
 
     [Test]
     public async Task RealClaude_RunAsync_WhenAuthenticated_ReturnsResponse()
@@ -23,7 +24,11 @@ public async Task RealClaude_RunAsync_WhenAuthenticated_ReturnsResponse()
                 NoSessionPersistence = true,
             });
 
-            var result = await thread.RunAsync(ReplyWithOkOnlyPrompt);
+            using var timeoutCts = new CancellationTokenSource(TestTimeout);
+            var result = await thread.RunAsync(ReplyWithOkOnlyPrompt, new TurnOptions
+            {
+                CancellationToken = timeoutCts.Token,
+            });
 
             await Assert.That(string.IsNullOrWhiteSpace(result.FinalResponse)).IsFalse();
         }

ClaudeCodeSharpSDK.Tests/Shared/RealClaudeTestSupport.cs

@@ -75,6 +75,7 @@ private static bool IsAuthenticated(string executablePath)
     {
         var startInfo = new ProcessStartInfo(executablePath)
         {
+            RedirectStandardInput = true,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
             UseShellExecute = false,
@@ -89,6 +90,7 @@ private static bool IsAuthenticated(string executablePath)
             return false;
         }
 
+        process.StandardInput.Close();
         var standardOutput = process.StandardOutput.ReadToEnd();
         var standardError = process.StandardError.ReadToEnd();
         process.WaitForExit();

ClaudeCodeSharpSDK/Internal/ClaudeCliMetadataReader.cs

@@ -320,6 +320,7 @@ private static string ReadInstalledVersion(string executablePath)
     {
         var startInfo = new ProcessStartInfo(executablePath)
         {
+            RedirectStandardInput = true,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
             UseShellExecute = false,
@@ -331,6 +332,7 @@ private static string ReadInstalledVersion(string executablePath)
                             ?? throw new InvalidOperationException(
                                 string.Concat(StartExecutableFailedMessagePrefix, Space, MessageQuote, executablePath, MessageQuote, MessageSuffix));
 
+        process.StandardInput.Close();
         var standardOutput = process.StandardOutput.ReadToEnd();
         var standardError = process.StandardError.ReadToEnd();
         process.WaitForExit();
@@ -359,6 +361,7 @@ private static (string? LatestVersion, string? ErrorMessage) ProbeLatestPublishe
             var gitExecutable = OperatingSystem.IsWindows() ? string.Concat(GitExecutableName, ExecutableExtension) : GitExecutableName;
             var startInfo = new ProcessStartInfo(gitExecutable)
             {
+                RedirectStandardInput = true,
                 RedirectStandardOutput = true,
                 RedirectStandardError = true,
                 UseShellExecute = false,
@@ -376,6 +379,7 @@ private static (string? LatestVersion, string? ErrorMessage) ProbeLatestPublishe
                 return (null, StartGitProcessFailedMessage);
             }
 
+            process.StandardInput.Close();
             var standardOutput = process.StandardOutput.ReadToEnd();
             var standardError = process.StandardError.ReadToEnd();
             process.WaitForExit();