Skip to content

Commit 20fdf47

Browse files
committed
fix #277-modify GraphSPARQLExampleTest so it can pass an appClient and adminClient so GraphSPARQLExample connects to the unit tests db when run as a unit test
1 parent 38171db commit 20fdf47

File tree

2 files changed

+15
-20
lines changed

2 files changed

+15
-20
lines changed

src/main/java/com/marklogic/client/example/extension/GraphSPARQLExample.java

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,27 @@ public class GraphSPARQLExample {
3333
public static void main(String... args) throws IOException {
3434
ExampleProperties props = Util.loadProperties();
3535

36-
installExtensions(props);
37-
3836
DatabaseClient appClient = DatabaseClientFactory.newClient(
3937
props.host, props.port,
4038
props.writerUser, props.writerPassword, props.authType);
39+
DatabaseClient adminClient = DatabaseClientFactory.newClient(
40+
props.host, props.port,
41+
props.adminUser, props.adminPassword, props.authType);
42+
run(appClient, adminClient);
43+
appClient.release();
44+
adminClient.release();
45+
}
46+
47+
public static void run(DatabaseClient appClient, DatabaseClient adminClient) throws IOException {
48+
installExtensions(adminClient);
4149

4250
insertGraph(appClient);
4351

4452
runQuery(appClient);
4553

4654
deleteGraph(appClient);
4755

48-
appClient.release();
49-
50-
uninstallExtensions(props);
56+
uninstallExtensions(adminClient);
5157
}
5258
public static void runQuery(DatabaseClient appClient) throws IOException {
5359
SPARQLManager sparqlMgr = new SPARQLManager(appClient);
@@ -92,33 +98,21 @@ public static void deleteGraph(DatabaseClient appClient) throws IOException {
9298

9399
System.out.println("deleted graph");
94100
}
95-
public static void installExtensions(ExampleProperties props) throws IOException {
96-
DatabaseClient adminClient = DatabaseClientFactory.newClient(
97-
props.host, props.port,
98-
props.adminUser, props.adminPassword, props.authType);
99-
101+
public static void installExtensions(DatabaseClient adminClient) throws IOException {
100102
System.out.println("installing extensions");
101103

102104
GraphManager.install(adminClient);
103105
SPARQLManager.install(adminClient);
104106

105107
System.out.println("installed extensions");
106-
107-
adminClient.release();
108108
}
109-
public static void uninstallExtensions(ExampleProperties props) throws IOException {
110-
DatabaseClient adminClient = DatabaseClientFactory.newClient(
111-
props.host, props.port,
112-
props.adminUser, props.adminPassword, props.authType);
113-
109+
public static void uninstallExtensions(DatabaseClient adminClient) throws IOException {
114110
System.out.println("uninstalling extensions");
115111

116112
GraphManager.uninstall(adminClient);
117113
SPARQLManager.uninstall(adminClient);
118114

119115
System.out.println("uninstalled extensions");
120-
121-
adminClient.release();
122116
}
123117
}
124118

src/test/java/com/marklogic/client/test/example/extension/GraphSPARQLExampleTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import org.junit.Test;
88

9+
import com.marklogic.client.test.Common;
910
import com.marklogic.client.example.extension.GraphSPARQLExample;
1011

1112
public class GraphSPARQLExampleTest {
@@ -17,7 +18,7 @@ public void testMain() {
1718

1819
boolean succeeded = false;
1920
try {
20-
GraphSPARQLExample.main(new String[0]);
21+
GraphSPARQLExample.run(Common.newClient(), Common.newAdminClient());
2122
succeeded = true;
2223
} catch (IOException e) {
2324
e.printStackTrace();

0 commit comments

Comments
 (0)