#578 - Check for minHosts; #680 - Removed temp files

Author: vivekmuniyandi

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/HostAvailabilityListener.java

@@ -130,6 +130,9 @@ public HostAvailabilityListener withSuspendTimeForHostUnavailable(Duration
    */
   public HostAvailabilityListener withMinHosts(int numHosts) {
     if (numHosts <= 0) throw new IllegalArgumentException("numHosts must be > 0");
+    int numConfigHosts = moveMgr.readForestConfig().getPreferredHosts().length;
+    if (numHosts > numConfigHosts) throw new IllegalArgumentException
+      ("numHosts must be less than or equal to the number of hosts in the cluster");
     this.minHosts = numHosts;
     return this;
   }

marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/ExportToWriterListenerTest.java

@@ -116,5 +116,6 @@ record -> {
       while ( reader.readLine() != null ) lines++;
       assertEquals( "There should be 100 lines in the output file", 100, lines );
     }
+    if(outputFile.exists()) outputFile.delete();
   }
 }

marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/QueryBatcherIteratorTest.java

@@ -148,6 +148,7 @@ public void test_A_OnDiskIterator() throws Exception {
 
     if ( failures2.length() > 0 ) fail(failures2.toString());
     assertEquals(numDocs, successDocs2.get());
+    if(tempFile.exists()) tempFile.delete();
   }
 
   @Test

marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/WriteBatcherTest.java

@@ -277,6 +277,16 @@ public void testListenerManagement() {
     batcher.setBatchFailureListeners(null);
     failureListeners = batcher.getBatchFailureListeners();
     assertEquals(0, failureListeners.length);
+
+    try {
+      HostAvailabilityListener ha = new HostAvailabilityListener(moveMgr)
+        .withMinHosts(2);
+      fail("should have thrown IllegalArgumentException since minHosts was " +
+        "set to a number greater than the number of hosts in the cluster");
+    } catch (IllegalArgumentException e) {
+      logger.debug("[testListenerManagement] threw expected exception since " +
+        "HostAvailabilityListener was initialized with greater minHosts: " + e);
+    }
   }
 
   /*