Merge pull request #1719 from BillFarber/task/fixInvokeErrorMessage

Invoke errors are now forced to be JSON.

Author: BillFarber

marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java

@@ -4229,7 +4229,7 @@ private Request.Builder setErrorFormatIfNecessary(Request.Builder requestBuilder
 		// server defaults to 'compatible'. If the error format is 'compatible', a block of HTML is sent back which
 		// causes an error that prevents the user from seeing the actual error from the server. So for all eval calls,
 		// X-Error-Accept is used to request any errors back as JSON so that they can be handled correctly.
-		if ("eval".equals(path)) {
+		if ("eval".equals(path) || ("invoke".equals(path))) {
 			requestBuilder.addHeader(HEADER_ERROR_FORMAT, "application/json");
 		}
 		return requestBuilder;

marklogic-client-api/src/test/java/com/marklogic/client/test/EvalTest.java

@@ -85,6 +85,20 @@ void invalidJavascript() {
 		  "https://docs.marklogic.com/guide/rest-dev/intro#id_34966; actual error: " + message);
   }
 
+	@Test
+	void invalidJavascriptModule() {
+		FailedRequestException ex = assertThrows(FailedRequestException.class, () ->
+			Common.evalClient.newServerEval().modulePath("/data/moduleDoesNotExist.sjs").eval()
+		);
+		String message = ex.getServerMessage();
+		assertTrue(
+			message.contains("Module /data/moduleDoesNotExist.sjs not found"),
+			"The error message from the server is expected to contain the actual error, which in this case " +
+				"is due to a missing module. In order for this to happen, the Java Client should send the " +
+				"X-Error-Accept header per the docs at https://docs.marklogic.com/guide/rest-dev/intro#id_34966; " +
+				"actual error: " + message);
+	}
+
   @Test
   void invalidXQuery() {
 	  FailedRequestException ex = assertThrows(FailedRequestException.class, () ->