fix #762 - throw ForbiddenUserException when 403 is returned and it's not a content version required

Author: sammefford

src/main/java/com/marklogic/client/impl/OkHttpServices.java

@@ -493,10 +493,6 @@ public Response apply(Request.Builder funcBuilder) {
         throw new FailedRequestException(
           "Content version required to delete document", failure);
       }
-      throw new FailedRequestException(
-        "Precondition required to delete document", failure);
-    } else if (status == STATUS_FORBIDDEN) {
-      FailedRequest failure = extractErrorFields(response);
       throw new ForbiddenUserException(
         "User is not allowed to delete documents", failure);
     }
@@ -1303,10 +1299,6 @@ private TemporalDescriptor putPostDocumentImpl(RequestLogger reqlog, String meth
         throw new FailedRequestException(
           "Content version required to write document", failure);
       }
-      throw new FailedRequestException(
-        "Precondition required to write document", failure);
-    } else if (status == STATUS_FORBIDDEN) {
-      FailedRequest failure = extractErrorFields(response);
       throw new ForbiddenUserException(
         "User is not allowed to write documents", failure);
     }

src/test/java/com/marklogic/client/test/InvalidUserTest.java

@@ -16,12 +16,16 @@
 package com.marklogic.client.test;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import org.junit.Test;
 
 import com.marklogic.client.DatabaseClient;
 import com.marklogic.client.DatabaseClientFactory;
 import com.marklogic.client.FailedRequestException;
+import com.marklogic.client.ForbiddenUserException;
 import com.marklogic.client.DatabaseClientFactory.Authentication;
 import com.marklogic.client.document.TextDocumentManager;
 import com.marklogic.client.io.StringHandle;
@@ -58,4 +62,22 @@ public void testInvalidUserAuth() {
         assertEquals(expectedException, exception);
 
     }
+
+    @Test
+    public void test_issue_762() {
+        DatabaseClient readOnlyClient = DatabaseClientFactory.newClient(
+            Common.HOST, Common.PORT, "rest-reader", "x", Authentication.DIGEST);
+        try {
+            readOnlyClient.newDocumentManager().writeAs("test.txt", "test");
+            fail("reader could write a document, but shouldn't be able to");
+        } catch (ForbiddenUserException e) {
+            String message = e.getFailedRequest().getMessageCode();
+            int statusCode = e.getFailedRequest().getStatusCode();
+            assertNotNull("Error Message is null", message);
+            assertTrue("Error Message", message.equals("SEC-PRIV"));
+            assertTrue("Status code", (statusCode == 403));
+        } finally {
+            readOnlyClient.release();
+        }
+    }
 }