more minor optimizations

Author: mmoll

MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php

@@ -91,7 +91,7 @@ public function process(File $phpcsFile, $stackPtr)
             $previous = $tokens[($i - 1)];
 
             // Skip nested arrays.
-            if ((in_array($current['code'], $this->arrayTokens)) === true) {
+            if (in_array($current['code'], $this->arrayTokens, true) === true) {
                 if ($current['code'] === T_ARRAY) {
                     $i = ($current['parenthesis_closer'] + 1);
                 } else {

MO4/Sniffs/Formatting/AlphabeticalUseStatementsSniff.php

@@ -38,7 +38,7 @@
 class AlphabeticalUseStatementsSniff extends UseDeclarationSniff
 {
 
-    const NAMESPACE_SEPRATOR_STRING = '\\';
+    const NAMESPACE_SEPARATOR_STRING = '\\';
 
     /**
      * Sorting order, can be one of:
@@ -50,7 +50,6 @@ class AlphabeticalUseStatementsSniff extends UseDeclarationSniff
      */
     public $order = 'dictionary';
 
-
     /**
      * Supported ordering methods
      *
@@ -83,7 +82,7 @@ class AlphabeticalUseStatementsSniff extends UseDeclarationSniff
      *
      * @var string
      */
-    private $currentFile = null;
+    private $currentFile;
 
 
     /**
@@ -239,9 +238,7 @@ private function getUseStatementAsString(
             $useLength++;
         }
 
-        $useStr = $phpcsFile->getTokensAsString($stackPtr, $useLength);
-
-        return $useStr;
+        return $phpcsFile->getTokensAsString($stackPtr, $useLength);
 
     }//end getUseStatementAsString()
 
@@ -398,11 +395,11 @@ private function dictionaryCompare($a, $b)
                 continue;
             }
 
-            if ($a[$i] === self::NAMESPACE_SEPRATOR_STRING) {
+            if ($a[$i] === self::NAMESPACE_SEPARATOR_STRING) {
                 return -1;
             }
 
-            if ($b[$i] === self::NAMESPACE_SEPRATOR_STRING) {
+            if ($b[$i] === self::NAMESPACE_SEPARATOR_STRING) {
                 return 1;
             }
 

MO4/Sniffs/Formatting/UnnecessaryNamespaceUsageSniff.php

@@ -117,8 +117,7 @@ public function process(File $phpcsFile, $stackPtr)
                     $className,
                     $namespace,
                     $nsSep,
-                    ($classNameEnd - 1),
-                    false
+                    ($classNameEnd - 1)
                 );
             } else {
                 // Doc comment block.
@@ -171,7 +170,7 @@ public function process(File $phpcsFile, $stackPtr)
                             PREG_SPLIT_NO_EMPTY
                         );
                         foreach ($typeTokens as $typeToken) {
-                            if (true === in_array($typeToken, $useStatements)) {
+                            if (true === in_array($typeToken, $useStatements, true)) {
                                 continue;
                             }
 

MO4/Sniffs/Strings/VariableInDoubleQuotedStringSniff.php

@@ -37,14 +37,15 @@ class VariableInDoubleQuotedStringSniff implements Sniff
      *
      * @var File
      */
-    private $phpCsFile = null;
+    private $phpCsFile;
 
 
     /**
      * Registers the tokens that this sniff wants to listen for.
      *
      * @return array(int)
-     * @see    Tokens.php
+     *
+     * @see Tokens.php
      */
     public function register()
     {