Skip to content

Act on linter hints from cppcheck #2096

@willend

Description

@willend

Using the new --lint flag of mctest (corresponding to the --c-lint of mcrun) I have tested the generated c-code across the McStas instruments via the cppcheck static code analyser. (Warning: The run took a couple of days to complete!)

Most of the output relates to missing free() calls, lack of protection in case of failed malloc(), uninitialised struct members...

The output is available in html table form here and a .tgz file here
(was also added as a column to today's test output)

The length of the compile_stdout.txt files are a hint wrt. work is needed - mostly in the "advanced" instruments... :-)
(@mads-bertelsen Union stuff and @farhi e.g. Isotropic_Sqw)

I have started fixing the instruments "bottom up" and the 4.0K/8.0K outputs at the end are "clean" - nothing left to fix there.

@mads-bertelsen @farhi @Lomholy status update:

McStas is "close to done", big chunks of output still for these instruments:

  • Conditional_test
  • Logger_test done
  • Test_texture (I think I fixed ~ half)
  • IncoherentPhonon_test
  • ILL_SALSA
  • Supermirror_thin_substrate done
  • FZJ_BenchmarkSfin2dene

Common denominators for "everything else" has been lack of error-handling on malloc()'s, fopen()'s and un-initialised vars...

For McXtrace, this will have to wait until a later point. :-)

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions