From f20744a239feca5b3249ea7360b44cc84c5fa24e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Povilas=20Balzaravi=C4=8Dius?= Date: Thu, 21 May 2026 19:30:05 +0300 Subject: [PATCH] R1 Neo: Disable blue LED Sometimes, when device is disconnected from phone, the blue LED turns on and does not shut down even when the app connects to the companion again. Sending a message turns off the LED. This does not happen all the time when phone is disconnected and unfortunately I do not know how to reproduce. But other users in old Discord instance also confirmed the same issue. The main problem is that turned on LED drain the battery. I've checked, other variants of the same just disable this LED at all, so followed the same pattern here. Tested the firmware on my own device. --- variants/muziworks_r1_neo/R1NeoBoard.h | 4 ++-- variants/muziworks_r1_neo/variant.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/variants/muziworks_r1_neo/R1NeoBoard.h b/variants/muziworks_r1_neo/R1NeoBoard.h index c56f1f5c2e..5e4a2c8aa5 100644 --- a/variants/muziworks_r1_neo/R1NeoBoard.h +++ b/variants/muziworks_r1_neo/R1NeoBoard.h @@ -27,14 +27,14 @@ class R1NeoBoard : public NRF52BoardDCDC { #if defined(P_LORA_TX_LED) void onBeforeTransmit() override { digitalWrite(P_LORA_TX_LED, HIGH); // turn TX LED on - #if defined(LED_BLUE) + #if defined(LED_BLUE) && LED_BLUE >= 0 // turn off that annoying blue LED before transmitting digitalWrite(LED_BLUE, LOW); #endif } void onAfterTransmit() override { digitalWrite(P_LORA_TX_LED, LOW); // turn TX LED off - #if defined(LED_BLUE) + #if defined(LED_BLUE) && LED_BLUE >= 0 // do it after transmitting too, just in case digitalWrite(LED_BLUE, LOW); #endif diff --git a/variants/muziworks_r1_neo/variant.h b/variants/muziworks_r1_neo/variant.h index 92046d61af..e25f488674 100644 --- a/variants/muziworks_r1_neo/variant.h +++ b/variants/muziworks_r1_neo/variant.h @@ -80,7 +80,7 @@ extern "C" /* LEDs */ #define LED_GREEN (36) // P1.04 (28) GRN_LED_RAK -#define LED_BLUE (28) // P0.28 (31) BLU_LED_RAK +#define LED_BLUE (-1) // Disable annoying flashing caused by Bluefruit #define LED_BUILTIN (0xFF)