[script] added 30 minute timeout retry when connection is unsuccessful

Author: MF Softworks

README.md

@@ -13,7 +13,8 @@ The script will gather information:
 - Network
 - Hard Drives
 - System OS
-- Current UTC Timestamp
+- System Uptime
+- UTC Timestamp
 
 The script will produce a JSON output at 5 second intervals for use with any software or server accepting a JSON input.
 Example:
@@ -65,29 +66,41 @@ Clone the script with `git clone`.
 
 Install Python.
 
-If any library is missing do `pip install` *library*.
+If any library is missing do `pip3 install` *library*.
 
 To test the script output run with `python3 monitor.py`.
 
-### Linux Autostart
+### **Linux Autostart**
 
 Create a cron job to run the script on every boot.
 
 Edit cron with `crontab -e`.
 
-Add the script at the bottom of the cron list as `@reboot python3 /path/to/script/monitor.py &`.
+Add the script at the bottom of the cron list as `@reboot /usr/bin/python3 /path/to/script/monitor.py &`.
 
-### Windows Autostart
+### **Windows Autostart**
 
 `Windows/monitor.bat` and `Windows/monitor.vbs` scripts are included.
 
 `monitor.bat` will call python to launch `monitor.py`.
 
 `monitor.vbs` silently calls `monitor.bat` to run in the background.
 
-To create an autostart for Windows open the startup folder with keyboard `Windows + R`, enter `shell:startup` and create a shortcut here to `monitor.vbs`. 
+To create an autostart for Windows open start menu and search for `Task Scheduler`.
 
-This will run the script in the background on every boot.
+Select `Create Task`.
+
+Enter a name e.g. monitor.
+
+Add new trigger at login.
+
+Add a new action and select the `Windows/monitor.vbs` script.
+
+**Unselect** Stop task if it runs longer than 3 days.
+
+Select Okay.
+
+A new task will be created that runs the python monitoring script in the background every time a user starts the system and logs in.
 
 ## Author
 

monitor.py

@@ -56,7 +56,7 @@ def main():
     print("System Uptime:")
     print(uptime)
 
-    ## Set Machine Info
+    # Set Machine Info
     machine = {
     	"hostname" : hostname,
         "system" : system,
@@ -104,21 +104,30 @@ def get_bandwidth():
     return network
 
 def send_data(data):
-    try:
-        endpoint = "http://monitor.localhost.local/api/"
-        response = requests.get(url = endpoint, params = {"data" : data})
-        print("\nGET:")
-        print("Response:", response.status_code)
-        print("Headers:")
-        pprint.pprint(response.headers)
-        print("Content:", response.content)
+    # Attempt to send data up to 30 times
+    for attempt in range(30):
         try:
-            print("JSON Content:")
-            pprint.pprint(response.json())
-        except:
-            print("No JSON content")
-    except requests.exceptions.RequestException as e:
-        print("\nGET Error:\n",e)
+            # endpoint = monitoring server
+            endpoint = "http://monitor.localhost.local/api/"
+            response = requests.get(url = endpoint, params = {"data" : data})
+            print("\nGET:")
+            print("Response:", response.status_code)
+            print("Headers:")
+            pprint.pprint(response.headers)
+            print("Content:", response.content)
+            # Attempt printing response in JSON if possible
+            try:
+                print("JSON Content:")
+                pprint.pprint(response.json())
+            except:
+                print("No JSON content")
+            break
+        except requests.exceptions.RequestException as e:
+            print("\nGET Error:\n",e)
+            # Sleep 1 minute before retrying
+            time.sleep(60)
+    else:
+        # If no connection established for half an hour, kill script
         exit(0)
 
 while True: