[W1][Codeunit][7312][Create Pick] Add integration event OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument in procedure CreateWhseDocPlaceLine

[mavohra]

Why do you need this change?

We need to intercept the warehouse activity line after its Source Document field has been assigned inside the CreateWhseDocPlaceLine repeat loop in Codeunit 7312 "Create Pick", and before TempWarehouseActivityLine.Delete() removes the temporary line. The goal is to allow a subscriber to modify fields on WarehouseActivityLine, such as overriding or supplementing the Source Document assignment based on a custom Whse. Document Type value that the standard exclusion filter does not account for.

The standard code assigns WarehouseActivityLine."Source Document" via WhseManagement.GetWhseActivSourceDocument only when the document type is not Internal Pick or Movement Worksheet. There is no way for a subscriber to extend the set of document types that should be excluded from this assignment, or to adjust any other WarehouseActivityLine field at this point after the source document is resolved and before the temporary line is deleted.

No event currently exists in this position inside the CreateWhseDocPlaceLine loop. The event OnCreateWhseDocPlaceLineOnAfterSetFilters fires before the loop starts at the filter setup stage and does not provide access to the fully initialized WarehouseActivityLine record. OnCreateWhseDocPlaceLineOnAfterTransferTempWhseActivLineToWhseActivLine fires earlier in the iteration before the source document assignment, so it cannot be used to react to the final Source Document value.

Describe the request

Add an integration event OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument in CreateWhseDocPlaceLine in Codeunit 7312 "Create Pick" after the conditional Source Document assignment on WarehouseActivityLine and before TempWarehouseActivityLine.Delete().

if not (WarehouseActivityLine."Whse. Document Type" in [
                                        WarehouseActivityLine."Whse. Document Type"::"Internal Pick",
                                        WarehouseActivityLine."Whse. Document Type"::"Movement Worksheet"])
then
    WarehouseActivityLine."Source Document" := WhseManagement.GetWhseActivSourceDocument(WarehouseActivityLine."Source Type", WarehouseActivityLine."Source Subtype");

OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument(WarehouseActivityLine); // <---- New Event
TempWarehouseActivityLine.Delete();

Event Signature:

[IntegrationEvent(false, false)]
local procedure OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument(var WarehouseActivityLine: Record "Warehouse Activity Line")
begin
end;

Alternatives evaluated: OnCreateWhseDocPlaceLineOnAfterTransferTempWhseActivLineToWhseActivLine fires before the source document is assigned, so a subscriber cannot react to or override the final Source Document value. OnCreateWhseDocPlaceLineOnAfterSetFilters fires before the loop begins and does not expose WarehouseActivityLine at all. No event currently exists between the source document assignment and the TempWarehouseActivityLine.Delete() call in this loop.
Internal work item: AB#636044

[github-actions]

Hi @mavohra,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Why the existing event is insufficient: Please explain why OnCreateWhseDocPlaceLineOnBeforeWhseActivLineInsert does not meet your scenario, since it already exposes var WarehouseActivityLine later in the same flow after Source Document assignment.
• Why a new per-iteration event is required: Please clarify why another event is needed inside the repeat-until loop at this location, and what specific behavior cannot be achieved with the existing event.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[mavohra]

Why OnCreateWhseDocPlaceLineOnBeforeWhseActivLineInsert is insufficient: That event fires after ValidateWhseActivLineQtyFIeldsFromCreateWhseDocPlaceLine, which calls Validate(Quantity) on WarehouseActivityLine. The Source Document field is already in play during that validate. A subscriber at that point cannot fix an incorrectly assigned Source Document before the validate has already run against it. That event also only fires when WarehouseActivityLine.Quantity > 0, so any iteration where quantity ends up zero after merging is missed entirely.

Why a new per-iteration event is required: OnCreateWhseDocPlaceLineOnBeforeWhseActivLineInsert fires once on the final accumulated line after all merging is complete. We need a hook per iteration, right after Source Document is assigned and before TempWarehouseActivityLine.Delete(), so a subscriber can clear or override the Source Document for a custom Whse. Document Type before any downstream validate or merge logic runs on it.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new integration event in the CreateWhseDocPlaceLine() procedure of Codeunit 7312 "Create Pick" after the conditional Source Document assignment and before TempWarehouseActivityLine.Delete().

Location in CreateWhseDocPlaceLine() procedure (around line 1851):

                if not (WarehouseActivityLine."Whse. Document Type" in [
                                                                WarehouseActivityLine."Whse. Document Type"::"Internal Pick",
                                                                WarehouseActivityLine."Whse. Document Type"::"Movement Worksheet"])
                then
                    WarehouseActivityLine."Source Document" := WhseManagement.GetWhseActivSourceDocument(WarehouseActivityLine."Source Type", WarehouseActivityLine."Source Subtype");

                OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument(WarehouseActivityLine);  // <-- New event
                TempWarehouseActivityLine.Delete();

Event Publisher (add at the end of the codeunit with other events):

    [IntegrationEvent(false, false)]
    local procedure OnCreateWhseDocPlaceLineOnAfterAssignSourceDocument(var WarehouseActivityLine: Record "Warehouse Activity Line")
    begin
    end;

---

File: CreatePick.Codeunit.al