Make sure deprecated is always a string#2271
Make sure deprecated is always a string#2271github-actions[bot] merged 9 commits intomicrosoft:mainfrom
Conversation
…DL files for consistency and clarity
…ndling of supported properties
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/patches/cssom.kdl
Outdated
| // The corresponding standardized property is not supported by | ||
| // anyone as of 2024-10. | ||
| property webkitLineClamp deprecated=#false | ||
| property webkitLineClamp supported=#true |
There was a problem hiding this comment.
A better way would be to remove the field through removals, although it's not supported yet. Maybe that should be the first step.
There was a problem hiding this comment.
Can you share the syntax for it @saschanaz I can't imagine it
There was a problem hiding this comment.
Something like
removals {
interface CSSStyleProperties {
property webkitLineClamp deprecated=#null
}
}Or perhaps it's easier to keep using each property's own type, like deprecated="" and let it converted to null via the removal conversion function. Either way would be fine for me.
|
Yay @saschanaz |
…ance TypeScript handling for empty objects
|
I have updated it @saschanaz |
|
You can push directly Btw @saschanaz |
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
No description provided.