An idea (working) for enabling the menu over telnet

[mpower-codeworks]

Hello, first-timer here. I have an idea for EDIT and I would
like to see what you think. I have tried it out, and I am
using it right now to write this with MS-EDIT from an Apple II.

The Apple II is connected to Windows via telnet. I use KTS Telnet
Server for the connection.

I made a small change to EDIT that allows this to work. I modified
the menu trigger to fire from just an ESC keypress. This enables
menu usage when a machine doesn't have an alt key or if the
connection doesn't handle alt well.

In regular modern usage of EDIT with this change, using ESC
feels natural and so far I haven't experienced any negative
effects.

I understand that the official EDIT supports ESC-F to launch the
menu, but honestly I feel it could be improved. If I stress
ESC-F repeatedly the trigger can stop working. Also, over telnet
it only works maybe once or twice from twenty tries.

My idea is: allow a single ESC keypress to trigger the menu.

It improves usability for regular usage and it's also pretty cool
to use EDIT from an Apple II. It might benefit other remote
machines as well.

I haven't tried Mac or Linux builds yet, only Windows. Here
is the modification to tui.rs around line 3172:

/* =====================================
** modified so ESC alone opens the menus
** =====================================
*/
let keyboard_focus = accelerator != '\0'
&& !contains_focus
&& (
    self.consume_shortcut(kbmod::ALT | InputKey::new(accelerator as u32))
    || (accelerator == 'F' && self.consume_shortcut(vk::ESCAPE))
);
//let keyboard_focus = accelerator != '\0'
//   && !contains_focus
//   && self.consume_shortcut(kbmod::ALT | InputKey::new(accelerator as u32));

/* ==========
** end modify
** ==========
*/

I've been thinking about a single ESC for menu exit as well,
but I haven't played around with it enough yet during dir/file
selection or other submenus to see if that's a good/bad idea.

I put a copy of the modified file and some photos of using EDIT
from an Apple II here:
https://github.com/mpower-codeworks/MS-EDIT-ESC-TELNET

Thank you,
m.power