-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Labels
debtCode quality issuesCode quality issues
Description
Summary
The pet-uv crate has incomplete TODO items related to workspace handling that should be addressed for complete uv environment support.
TODO Items
1. crates/pet-uv/src/lib.rs line 142
// TODO: maybe check for workspace in parent folders?Context: When identifying uv environments, the code doesn't currently look for workspaces in parent directories. This could miss environments that are part of a parent workspace.
2. crates/pet-uv/src/lib.rs line 162
// TODO: check for workspace members/excludesContext: uv workspaces can have members and excludes patterns. Currently these are not being checked, which could lead to incorrect environment association.
uv Workspace Configuration Reference
From uv documentation, pyproject.toml can contain:
[tool.uv.workspace]
members = ["packages/*"]
exclude = ["packages/excluded"]Recommended Implementation
- When identifying a uv environment, walk up parent directories looking for
pyproject.tomlwith[tool.uv.workspace] - Parse workspace
membersandexcludeglobs - Check if current project matches member patterns and doesn't match exclude patterns
- Associate environment with the workspace root if applicable
Priority
Medium - Improves accuracy of uv environment detection in monorepo/workspace setups.
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issues