Merge pull request #359 from microsoftgraph/feature/baseRequestAdapter

Setup BaseRequestAdapter

Author: andrueastman

src/Microsoft.Graph.Core/CoreConstants.cs

@@ -26,7 +26,7 @@ public static class Headers
             public const string SdkVersionHeaderName = "SdkVersion";
 
             /// SDK Version header
-            public const string SdkVersionHeaderValueFormatString = "{0}-dotnet-{1}.{2}.{3}";
+            public const string SdkVersionHeaderValueFormatString = "graph-dotnet-core/{0}.{1}.{2}";
 
             /// Content-Type header
             public const string FormUrlEncodedContentType = "application/x-www-form-urlencoded";

src/Microsoft.Graph.Core/Microsoft.Graph.Core.csproj

@@ -100,9 +100,9 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="6.15.0" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
-    <PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.0.26" />
+    <PackageReference Include="Microsoft.Kiota.Abstractions" Version="1.0.27" />
     <PackageReference Include="Microsoft.Kiota.Authentication.Azure" Version="1.0.7" />
     <PackageReference Include="Microsoft.Kiota.Http.HttpClientLibrary" Version="1.0.17" />
-    <PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.0.10" />
+    <PackageReference Include="Microsoft.Kiota.Serialization.Json" Version="1.0.11" />
   </ItemGroup>
 </Project>

src/Microsoft.Graph.Core/Models/Date.cs

@@ -21,7 +21,7 @@ public interface IUploadSession: IParsable
         /// <summary>
         /// The ranges yet to be uploaded to the server
         /// </summary>
-        IEnumerable<string> NextExpectedRanges { get; set; }
+        List<string> NextExpectedRanges { get; set; }
 
         /// <summary>
         /// The URL for upload

src/Microsoft.Graph.Core/Models/Duration.cs

@@ -22,7 +22,7 @@ internal class UploadSession : IUploadSession
         /// <summary>
         /// The ranges yet to be uploaded to the server
         /// </summary>
-        public IEnumerable<string> NextExpectedRanges { get; set; }
+        public List<string> NextExpectedRanges { get; set; }
 
         /// <summary>
         /// The URL for upload

src/Microsoft.Graph.Core/Models/IUploadSession.cs

@@ -13,7 +13,6 @@ namespace Microsoft.Graph
     using Microsoft.Kiota.Authentication.Azure;
     using System.Linq;
     using Microsoft.Kiota.Abstractions;
-    using Microsoft.Kiota.Http.HttpClientLibrary;
 
     /// <summary>
     /// A default client implementation.
@@ -45,7 +44,7 @@ public BaseClient(
         public BaseClient(
             string baseUrl,
             IAuthenticationProvider authenticationProvider
-            ): this(new HttpClientRequestAdapter(authenticationProvider , httpClient: GraphClientFactory.Create()){ BaseUrl = baseUrl })
+            ): this(new BaseGraphRequestAdapter(authenticationProvider){ BaseUrl = baseUrl })
         {
         }
 
@@ -70,7 +69,7 @@ public BaseClient(
         /// <param name="httpClient">The customized <see cref="HttpClient"/> to be used for making requests</param>
         public BaseClient(
             string baseUrl,
-            HttpClient httpClient):this(new HttpClientRequestAdapter(new AnonymousAuthenticationProvider(), httpClient: httpClient) { BaseUrl = baseUrl })
+            HttpClient httpClient):this(new BaseGraphRequestAdapter(new AnonymousAuthenticationProvider(), httpClient: httpClient) { BaseUrl = baseUrl })
         {
         }
 

src/Microsoft.Graph.Core/Models/TimeOfDay.cs

@@ -0,0 +1,31 @@
+// ------------------------------------------------------------------------------
+//  Copyright (c) Microsoft Corporation.  All Rights Reserved.  Licensed under the MIT License.  See License in the project root for license information.
+// ------------------------------------------------------------------------------
+
+namespace Microsoft.Graph
+{
+    using Microsoft.Kiota.Abstractions;
+    using Microsoft.Kiota.Abstractions.Authentication;
+    using Microsoft.Kiota.Abstractions.Serialization;
+    using Microsoft.Kiota.Http.HttpClientLibrary;
+    using System.Net.Http;
+
+    /// <summary>
+    /// The <see cref="IRequestAdapter"/> instance for use with microsoft graph
+    /// </summary>
+    public class BaseGraphRequestAdapter : HttpClientRequestAdapter
+    {
+        /// <summary>
+        /// The public constructor for <see cref="BaseGraphRequestAdapter"/>
+        /// </summary>
+        /// <param name="authenticationProvider">The authentication provider.</param>
+        /// <param name="graphClientOptions">The options for the graph client</param>
+        /// <param name="parseNodeFactory">The parse node factory.</param>
+        /// <param name="serializationWriterFactory">The serialization writer factory.</param>
+        /// <param name="httpClient">The native HTTP client.</param>
+        public BaseGraphRequestAdapter(IAuthenticationProvider authenticationProvider, GraphClientOptions graphClientOptions = null, IParseNodeFactory parseNodeFactory = null, ISerializationWriterFactory serializationWriterFactory = null, HttpClient httpClient = null)
+            : base(authenticationProvider, parseNodeFactory ?? ParseNodeFactoryRegistry.DefaultInstance, serializationWriterFactory ?? SerializationWriterFactoryRegistry.DefaultInstance, httpClient ?? GraphClientFactory.Create(graphClientOptions))
+        {
+        }
+    }
+}

src/Microsoft.Graph.Core/Models/UploadSession.cs

@@ -1,4 +1,4 @@
-// ------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 //  Copyright (c) Microsoft Corporation.  All Rights Reserved.  Licensed under the MIT License.  See License in the project root for license information.
 // ------------------------------------------------------------------------------
 namespace Microsoft.Graph
@@ -8,29 +8,14 @@ namespace Microsoft.Graph
     using System.Linq;
     using System.Net;
     using System.Net.Http;
-    using System.Reflection;
     using System.Net.Http.Headers;
     using Microsoft.Kiota.Http.HttpClientLibrary.Middleware;
-    using Microsoft.Kiota.Abstractions.Authentication;
+
     /// <summary>
     /// GraphClientFactory class to create the HTTP client
     /// </summary>
     public static class GraphClientFactory
     {
-        /// The key for the SDK version header.
-        private static readonly string SdkVersionHeaderName = CoreConstants.Headers.SdkVersionHeaderName;
-
-        /// The version for current assembly.
-        private static Version assemblyVersion = typeof(GraphClientFactory).GetTypeInfo().Assembly.GetName().Version;
-
-        /// The value for the SDK version header.
-        private static string SdkVersionHeaderValue = string.Format(
-                    CoreConstants.Headers.SdkVersionHeaderValueFormatString,
-                    "Graph",
-                    assemblyVersion.Major,
-                    assemblyVersion.Minor,
-                    assemblyVersion.Build);
-
         /// The default value for the overall request timeout.
         private static readonly TimeSpan defaultTimeout = TimeSpan.FromSeconds(100);
 
@@ -60,17 +45,19 @@ public static class GraphClientFactory
         /// </summary>
         /// <param name="version">The graph version to use.</param>
         /// <param name="nationalCloud">The national cloud endpoint to use.</param>
+        /// <param name="graphClientOptions">The <see cref="GraphClientOptions"/> to use with the client</param>
         /// <param name="proxy">The proxy to be used with created client.</param>
         /// <param name="finalHandler">The last HttpMessageHandler to HTTP calls.
         /// The default implementation creates a new instance of <see cref="HttpClientHandler"/> for each HttpClient.</param>
         /// <returns></returns>
         public static HttpClient Create(
+            GraphClientOptions graphClientOptions = null,
             string version = "v1.0",
             string nationalCloud = Global_Cloud,
             IWebProxy proxy = null,
             HttpMessageHandler finalHandler = null)
         {
-            IList<DelegatingHandler> handlers = CreateDefaultHandlers();
+            IList<DelegatingHandler> handlers = CreateDefaultHandlers(graphClientOptions);
             return Create(handlers, version, nationalCloud, proxy, finalHandler);
         }
 
@@ -109,7 +96,6 @@ public static HttpClient Create(
 
             var pipelineWithFlags = CreatePipelineWithFeatureFlags(handlers, finalHandler);
             HttpClient client = new HttpClient(pipelineWithFlags.Pipeline);
-            client.DefaultRequestHeaders.Add(SdkVersionHeaderName, SdkVersionHeaderValue);
             client.SetFeatureFlag(pipelineWithFlags.FeatureFlags);
             client.Timeout = defaultTimeout;
             client.BaseAddress = DetermineBaseAddress(nationalCloud, version);
@@ -120,10 +106,12 @@ public static HttpClient Create(
         /// <summary>
         /// Create a default set of middleware for calling Microsoft Graph
         /// </summary>
+        /// <param name="graphClientOptions">The <see cref="GraphClientOptions"/> to use with the client</param>
         /// <returns></returns>
-        public static IList<DelegatingHandler> CreateDefaultHandlers()
+        public static IList<DelegatingHandler> CreateDefaultHandlers(GraphClientOptions graphClientOptions = null)
         {
             return new List<DelegatingHandler> {
+                new GraphTelemetryHandler(graphClientOptions),
                 new OdataQueryHandler(),
                 new CompressionHandler(),
                 new RetryHandler(),