CSHARP-1931: ReIndex should ignore write concern.

Author: rstam

src/MongoDB.Driver.Core/Core/Operations/ReIndexOperation.cs

@@ -1,4 +1,4 @@
-/* Copyright 2016 MongoDB Inc.
+/* Copyright 2016-2017 MongoDB Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -71,11 +71,12 @@ public MessageEncoderSettings MessageEncoderSettings
         }
 
         /// <summary>
-        /// Gets or sets the write concern.
+        /// Gets or sets the write concern (ignored and will eventually be deprecated and later removed).
         /// </summary>
         /// <value>
         /// The write concern.
         /// </value>
+        // TODO: deprecate in 2.5 and remove in 3.0
         public WriteConcern WriteConcern
         {
             get { return _writeConcern; }
@@ -120,8 +121,7 @@ internal BsonDocument CreateCommand(SemanticVersion serverVersion)
         {
             return new BsonDocument
             {
-                { "reIndex", _collectionNamespace.CollectionName },
-                { "writeConcern", () => _writeConcern.ToBsonDocument(), Feature.CommandsThatWriteAcceptWriteConcern.ShouldSendWriteConcern(serverVersion, _writeConcern) }
+                { "reIndex", _collectionNamespace.CollectionName }
             };
         }
 

src/MongoDB.Driver.Legacy/MongoCollection.cs

@@ -1,4 +1,4 @@
-/* Copyright 2010-2016 MongoDB Inc.
+/* Copyright 2010-2017 MongoDB Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -1663,10 +1663,7 @@ public ReadOnlyCollection<IEnumerator> ParallelScanAs(Type documentType, Paralle
         /// <returns>A CommandResult.</returns>
         public virtual CommandResult ReIndex()
         {
-            var operation = new ReIndexOperation(_collectionNamespace, GetMessageEncoderSettings())
-            {
-                WriteConcern = _settings.WriteConcern
-            };
+            var operation = new ReIndexOperation(_collectionNamespace, GetMessageEncoderSettings());
             var result = ExecuteWriteOperation(operation);
             return new CommandResult(result);
         }

tests/MongoDB.Driver.Core.Tests/Core/Operations/ReIndexOperationTests.cs

@@ -106,30 +106,6 @@ public void Execute_should_throw_when_binding_is_null(
             });
         }
 
-        [SkippableTheory]
-        [ParameterAttributeData]
-        public void Execute_should_throw_when_a_write_concern_error_occurs(
-            [Values(false, true)]
-            bool async)
-        {
-            RequireServer.Check().Supports(Feature.CommandsThatWriteAcceptWriteConcern).ClusterType(ClusterType.ReplicaSet);
-            var actualVersion = CoreTestConfiguration.ServerVersion;
-            if (actualVersion.Major == 3 && actualVersion.Minor == 5 && actualVersion.Patch == 2)
-            {
-                // skip test on any version of 3.5.2
-                return; // TODO: remove later
-            }
-            EnsureCollectionExists();
-            var subject = new ReIndexOperation(_collectionNamespace, _messageEncoderSettings)
-            {
-                WriteConcern = new WriteConcern(9)
-            };
-
-            var exception = Record.Exception(() => ExecuteOperation(subject, async));
-
-            exception.Should().BeOfType<MongoWriteConcernException>();
-        }
-
         [Fact]
         public void CreateCommand_should_return_expected_result()
         {
@@ -144,31 +120,6 @@ public void CreateCommand_should_return_expected_result()
             result.Should().Be(expectedResult);
         }
 
-        [Theory]
-        [ParameterAttributeData]
-        public void CreateCommand_should_return_expected_result_when_WriteConcern_is_set(
-            [Values(null, 1, 2)]
-            int? w,
-            [Values(false, true)]
-            bool isWriteConcernSupported)
-        {
-            var writeConcern = w.HasValue ? new WriteConcern(w.Value) : null;
-            var subject = new ReIndexOperation(_collectionNamespace, _messageEncoderSettings)
-            {
-                WriteConcern = writeConcern
-            };
-            var serverVersion = Feature.CommandsThatWriteAcceptWriteConcern.SupportedOrNotSupportedVersion(isWriteConcernSupported);
-
-            var result = subject.CreateCommand(serverVersion);
-
-            var expectedResult = new BsonDocument
-            {
-                { "reIndex", _collectionNamespace.CollectionName },
-                { "writeConcern", () => writeConcern.ToBsonDocument(), writeConcern != null && isWriteConcernSupported }
-            };
-            result.Should().Be(expectedResult);
-        }
-
         // private methods
         public void EnsureCollectionExists()
         {

tests/MongoDB.Driver.Legacy.Tests/MongoCollectionTests.cs

@@ -2945,18 +2945,6 @@ public void TestReIndex()
             }
         }
 
-        [SkippableFact]
-        public void TestReIndexWriteConcern()
-        {
-            RequireServer.Check().Supports(Feature.CommandsThatWriteAcceptWriteConcern).ClusterType(ClusterType.ReplicaSet);
-            EnsureCollectionExists(_collection.Name);
-            var writeConcern = new WriteConcern(9, wTimeout: TimeSpan.FromMilliseconds(1));
-
-            var exception = Record.Exception(() => _collection.WithWriteConcern(writeConcern).ReIndex());
-
-            exception.Should().BeOfType<MongoWriteConcernException>();
-        }
-
         [Fact]
         public void TestRemove()
         {