PHPLIB-313 Check that MapReduce's finalize option is an instance of JavascriptInterface

Author: kvwalker

src/Operation/MapReduce.php

@@ -84,8 +84,8 @@ class MapReduce implements Executable
      *    This is not supported for server versions < 3.4 and will result in an
      *    exception at execution time if used.
      *
-     *  * finalize (MongoDB\BSON\Javascript): Follows the reduce method and
-     *    modifies the output.
+     *  * finalize (MongoDB\BSON\JavascriptInterface): Follows the reduce method
+     *    and modifies the output.
      *
      *  * jsMode (boolean): Specifies whether to convert intermediate data into
      *    BSON format between the execution of the map and reduce functions.
@@ -155,7 +155,7 @@ public function __construct($databaseName, $collectionName, JavascriptInterface
             throw InvalidArgumentException::invalidType('"collation" option', $options['collation'], 'array or object');
         }
 
-        if (isset($options['finalize']) && ! $options['finalize'] instanceof Javascript) {
+        if (isset($options['finalize']) && ! $options['finalize'] instanceof JavascriptInterface) {
             throw InvalidArgumentException::invalidType('"finalize" option', $options['finalize'], 'MongoDB\Driver\Javascript');
         }
 

tests/Operation/MapReduceFunctionalTest.php

@@ -64,6 +64,21 @@ function(stdClass $command) {
         $operation->execute($this->getPrimaryServer());
     }
 
+    public function testFinalize()
+    {
+        $this->createFixtures(3);
+
+        $map = new Javascript('function() { emit(this.x, this.y); }');
+        $reduce = new Javascript('function(key, values) { return Array.sum(values); }');
+        $out = ['inline' => 1];
+        $finalize = new Javascript('function(key, reducedValue) { return reducedValue; }');
+
+        $operation = new MapReduce($this->getDatabaseName(), $this->getCollectionName(), $map, $reduce, $out, ['finalize' => $finalize]);
+        $result = $operation->execute($this->getPrimaryServer());
+
+        $this->assertNotNull($result);
+    }
+
     public function testResult()
     {
         $this->createFixtures(3);