Skip to content

Conversation

@harikrishna0315
Copy link

What was fixed

The Caps Lock indicator could become inverted when the page was loaded with Caps Lock already enabled, because the state was toggled instead of synced.

What changed

  • Updated caps-warning.ts to prioritize event.getModifierState("CapsLock")
  • This ensures the indicator reflects the actual Caps Lock state rather than assuming a toggle
  • Added a safe fallback for environments where getModifierState is unavailable

Verification

  • Manually reproduced the issue by loading the page with Caps Lock enabled
  • Confirmed the indicator now shows the correct state immediately
  • Verified toggling Caps Lock behaves correctly afterward

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix Caps Lock indicator inversion on initial load". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - impr
 - fix
 - perf
 - refactor
 - revert
 - style
 - test

A correct version would look something like:

feat: add new feature (@github_username)
impr(quotes): add english quotes (@username)
fix(leaderboard): show user rank correctly (@user1, @user2, @user3)

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff assets Languages, themes, layouts, etc. packages Changes in local packages labels Feb 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 8, 2026
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 8, 2026
@harikrishna0315
Copy link
Author

Hi! The CI is asking for a Conventional Commits–style PR title.
I’m unable to edit the PR title from my side.

Could a maintainer please rename this PR to:

fix(caps-warning): correct Caps Lock indicator inversion (@harikrishna0315)

Thanks!

@fehmer
Copy link
Member

fehmer commented Feb 8, 2026

hi @harikrishna0315 , thank you for your contribution. There is already a PR #7478 fixing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. backend Server stuff frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants