impr(languages): add Bemba language (@kopachef)#7819
Open
kopachef wants to merge 1 commit intomonkeytypegame:masterfrom
Open
impr(languages): add Bemba language (@kopachef)#7819kopachef wants to merge 1 commit intomonkeytypegame:masterfrom
kopachef wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
Member
|
Hi @kopachef
Where does it say this? |
Author
Hi @fehmer, this is under the language guidelines here: https://github.com/monkeytypegame/monkeytype/blob/master/docs/CONTRIBUTING.md#language-guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Bemba language support to Monkeytype with three word lists:
bembabemba_1kbemba_10kBemba is a Bantu language and is the most commonly spoken language in Zambia, with roughly 5-6 million speakers. I have had this language support working on a personal Monkeytype fork at https://typing.martinnn.com, and I wanted to contribute the language data upstream so it can be used by the wider Monkeytype community.
Most of this data comes from work I did for my undergraduate thesis, where I built a morphological analyser for Bemba:
https://project-archive.inf.ed.ac.uk/ug4/20244657/ug4_proj.pdf
The language files use the BCP 47 tag
bem, and include the metadata requested in the language contribution guide:rightToLeft: falseligatures: falseorderedByFrequency: falseI also registered the new language variants in the schema and added them to a single Bemba language group.
Validation run locally:
Result:
Languages are all valid
One note: the older checklist item mentions adding languages to
_listand_groups. In the current codebase, those files have been replaced bypackages/schemas/src/ languages.tsandfrontend/src/ts/constants/languages.ts. This PR follows the current structure and passespnpm run check-assets-languages.Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCloses: n/a