aaudio: Make shutdown_with_error non-blocking.#838
Merged
Conversation
shutdown_with_error would block the state thread, preventing other streams from receiving updates. Instead, poll stream states and return early if a terminal state has not yet been reached. Make ERROR a waiting state so the state thread calls shutdown_with_error repeatedly to drive it to completion. Also adjust shutdown_with_error to handle a concurrent stream_stop causing the stream's terminal state to become PAUSED instead of the expected STOPPED.
kinetiknz
force-pushed
the
aaudio_state_deadlock
branch
from
8490e7a to
456cc4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutdown_with_error would block the state thread, preventing other streams from receiving updates. Instead, poll stream states and return early if a terminal state has not yet been reached. Make ERROR a waiting state so the state thread calls shutdown_with_error repeatedly to drive it to completion.
Also adjust shutdown_with_error to handle a concurrent stream_stop causing the stream's terminal state to become PAUSED instead of the expected STOPPED.
This significantly reduces the number of test timeouts observed in BMO 1988591.