From 5494920ccb35961b6ed2136f249ba51292e5a194 Mon Sep 17 00:00:00 2001 From: Alexander Moses Date: Tue, 27 Jan 2026 14:13:21 +0000 Subject: [PATCH 1/3] Bug-1915777: Make test tags theme aware This change updates the TestHeader and SubtestsRevisionHeader by making tag options aware of light. The changes made are: * Import theme hook in both TestHeader and SubtestsRevisionHeader * Update `styles` object in both TestHeader and SubtestsRevisionHeader to choose background color of span based on theme * Update color of tag based on theme * Add new colors to `styles/Colors.ts` --- .../OverTimeResultsView.test.tsx.snap | 10 +- .../__snapshots__/ResultsTable.test.tsx.snap | 2578 ++++++++++++++++- .../__snapshots__/ResultsView.test.tsx.snap | 10 +- .../SubtestsResultsView.test.tsx.snap | 50 +- .../SubtestsRevisionHeader.tsx | 101 +- src/components/CompareResults/TestHeader.tsx | 115 +- src/styles/Colors.ts | 10 + 7 files changed, 2728 insertions(+), 146 deletions(-) diff --git a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap index 2ddec09b0..8d9f068d8 100644 --- a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap +++ b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap @@ -640,27 +640,27 @@ exports[`Results View The table should match snapshot and other elements should class="fexjzun" > opt e10s fission stylo webrender diff --git a/src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap b/src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap index 4d75dfad9..23f8e4b71 100644 --- a/src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap +++ b/src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap @@ -84,6 +84,2552 @@ exports[`Results Table Should match snapshot 1`] = ` d="M15.41 7.41 14 6l-6 6 6 6 1.41-1.41L10.83 12z" /> +

+ Home +

+ + + +
+
+
+
+
+ +
+
+
+ + +
+
+ +
+
+
+
+
+
+ +
+ + +
+
+
+
+
+
+
+
+
    +
  • + + +
    +
    + try +
    +
    +
    +
    + + + + coconut + + + + + +
    +
    + +
    + johncleese@python.com +
    +
    +
    + +
    + Mar 29, 51, 00:00 UTC +
    +
    +
    +     + + you've got no arms left! + +
    + +
    +
    • +
+
+
+
+
+
+ + +
+
+ +
+
+
+
+
+
+ +
+ + +
+
+
+
+
+
+
+
+
    +
  • + + +
    +
    + try +
    +
    +
    +
    + + + + coconut + + + + + +
    +
    + +
    + johncleese@python.com +
    +
    +
    + +
    + Mar 29, 51, 00:00 UTC +
    +
    +
    +     + + you've got no arms left! + +
    + +
    +
    • +
+
+
+
+ + +
+
+
+ +
+
+
+
+
+
+

+ Results +

+ +

+ Compare with a base +

+
+

+
+
+ +
+
+

+
+
+
+
+
+
+
+
+
+
+ + +
+ +
+ +
+ +
+
+
+
+
+
+
+ + + + +
+
+
+
+
+
+ + + + +
+
+
+
+
+
+ + + + +
+
+
+
+
+ +
+
+
+
+
+ +
+
+ + Base + +
+
+
+ + New + +
+
+ +
+
+ + + +
+
+
+ + +
+
+
+ + Total Runs + +
+
+
+
+
+
+
+
+
+
+
+
+ + + a11yr + + dhtml.html + + +
+ + spam + + + + +
+
+
+ + opt + + + e10s + + + fission + + + stylo + + + webrender + +
+
+
+
+
+
+ + + Linux 18.04 + +
+
+
+ 776.97 ms + +
+
+ < +
+
+ 791.34 ms + +
+
+
+ + Regression +
+
+
+ + 1.85 % +
+
+ + Medium +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+ + + macOS 10.15 + +
+
+
+ 704.84 ms + +
+
+ < +
+
+ 712.44 ms + +
+
+
+ + Improvement +
+
+
+ + 1.08 % +
+
+ + Low +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+ + + Windows 10 + +
+
+
+ 643.54 ms + +
+
+ > +
+
+ 628.09 ms + +
+
+
+ - +
+
+
+ + -2.4 % +
+
+ + High +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+ + + a11yr + + dhtml.html + + +
+ + spam + + + + +
+
+
+ + opt + +
+
+
+
+
+
+ + + Windows 10 + +
+
+
+ 643.54 ms + +
+
+ > +
+
+ 628.09 ms + +
+
+
+ - +
+
+
+ + -24 % +
+
+ - +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +`; + +exports[`Results Table can load the sort parameters from the URL for a descending sort 1`] = ` + +`; + +exports[`Results Table can load the sort parameters from the URL for an ascending sort 1`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 1`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 2`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 3`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 4`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 5`] = ` + +`; + +exports[`Results Table for MannWhitneyResultsItem for mann-whitney-u testVersion Should match snapshot 1`] = ` + +
+
+
+
+
+