From f68a5b0313b385a7de5ead67d0ad8b1628af9626 Mon Sep 17 00:00:00 2001 From: Alexander Moses Date: Thu, 29 Jan 2026 14:13:55 +0000 Subject: [PATCH 1/3] Bug-1948879: Adding links to docs and source in banner Added links to PerfCompare docs and GitHub source in the Banner. --- .../OverTimeResultsView.test.tsx.snap | 2 +- .../__snapshots__/ResultsTable.test.tsx.snap | 2548 ++++++++++++++++- .../__snapshots__/ResultsView.test.tsx.snap | 2 +- .../SubtestsResultsView.test.tsx.snap | 10 +- src/__tests__/__snapshots__/App.test.tsx.snap | 60 + src/components/App.tsx | 22 + src/resources/Strings.tsx | 10 + 7 files changed, 2646 insertions(+), 8 deletions(-) diff --git a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap index f3bdc9916..7903056d6 100644 --- a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap +++ b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap @@ -449,7 +449,7 @@ exports[`Results View The table should match snapshot and other elements should role="columnheader" >
+ + +
+
+
+
+
+ +
+
+
+ + +
+
+ +
+
+
+
+
+
+ +
+ + +
+
+
+
+
+
+
+
+
    +
  • + + +
    +
    + try +
    +
    +
    +
    + + + + coconut + + + + + +
    +
    + +
    + johncleese@python.com +
    +
    +
    + +
    + Mar 29, 51, 00:00 UTC +
    +
    +
    +     + + you've got no arms left! + +
    + +
    +
    • +
+
+
+
+
+
+ + +
+
+ +
+
+
+
+
+
+ +
+ + +
+
+
+
+
+
+
+
+
    +
  • + + +
    +
    + try +
    +
    +
    +
    + + + + coconut + + + + + +
    +
    + +
    + johncleese@python.com +
    +
    +
    + +
    + Mar 29, 51, 00:00 UTC +
    +
    +
    +     + + you've got no arms left! + +
    + +
    +
    • +
+
+
+
+ + +
+
+
+ +
+
+
+
+
+
+

+ Results +

+ +

+ Compare with a base +

+
+

+
+
+ +
+
+

+
+
+
+
+
+
+
+
+
+
+ + +
+ +
+ +
+ +
+
+
+
+
+
+
+ + + + +
+
+
+
+
+
+ + + + +
+
+
+
+
+
+ + + + +
+
+
+
+
+ +
+
+
+
+
+ +
+
+ + Base + +
+
+
+ + New + +
+
+ +
+
+ + + +
+
+
+ + +
+
+
+ + Total Runs + +
+
+
+
+
+
+
+
+
+
+
+
+ + + a11yr + + dhtml.html + + +
+ + spam + + + + +
+
+
+ + opt + + + e10s + + + fission + + + stylo + + + webrender + +
+
+
+
+
+
+ + + Linux 18.04 + +
+
+
+ 776.97 ms + +
+
+ < +
+
+ 791.34 ms + +
+
+
+ + Regression +
+
+
+ + 1.85 % +
+
+ + Medium +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+ + + macOS 10.15 + +
+
+
+ 704.84 ms + +
+
+ < +
+
+ 712.44 ms + +
+
+
+ + Improvement +
+
+
+ + 1.08 % +
+
+ + Low +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+ + + Windows 10 + +
+
+
+ 643.54 ms + +
+
+ > +
+
+ 628.09 ms + +
+
+
+ - +
+
+
+ + -2.4 % +
+
+ + High +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+ + + a11yr + + dhtml.html + + +
+ + spam + + + + +
+
+
+ + opt + +
+
+
+
+
+
+ + + Windows 10 + +
+
+
+ 643.54 ms + +
+
+ > +
+
+ 628.09 ms + +
+
+
+ - +
+
+
+ + -24 % +
+
+ - +
+
+ + + B: + + + 1 + + + + + N: + + + 1 + + +
+
+
+
+ + + +
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +`; + +exports[`Results Table can load the sort parameters from the URL for a descending sort 1`] = ` + +`; + +exports[`Results Table can load the sort parameters from the URL for an ascending sort 1`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 1`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 2`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 3`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 4`] = ` + +`; + +exports[`Results Table can sort the table and persist the sort parameters to the URL 5`] = ` + +`; + +exports[`Results Table for MannWhitneyResultsItem for mann-whitney-u testVersion Should match snapshot 1`] = ` + +
+
+
+
+
+
@@ -316,6 +336,26 @@ exports[`App CompareResults or CompareOverTime loader Should render an error pag > #perfcompare:mozilla.org on Matrix + . + View the docs at + + + PerfCompare documentation + + . + View the source code on + + + GitHub + .
@@ -474,6 +514,26 @@ exports[`App CompareResults or CompareOverTime loader Should render an error pag > #perfcompare:mozilla.org on Matrix + . + View the docs at + + + PerfCompare documentation + + . + View the source code on + + + GitHub + .
diff --git a/src/components/App.tsx b/src/components/App.tsx index e02ae29fc..02c78c4b9 100644 --- a/src/components/App.tsx +++ b/src/components/App.tsx @@ -45,6 +45,18 @@ const contact: InfoStrings = { href: Strings.components.contact.href, }; +const docs: InfoStrings = { + text: Strings.components.docs.text, + linkText: Strings.components.docs.linkText, + href: Strings.components.docs.href, +}; + +const source: InfoStrings = { + text: Strings.components.source.text, + linkText: Strings.components.source.linkText, + href: Strings.components.source.href, +}; + type DivProps = React.HTMLProps; const AlertContainer = React.forwardRef( @@ -178,6 +190,16 @@ function App() { {contact.linkText} + {'. '} + {docs.text}{' '} + + {docs.linkText} + + {'. '} + {source.text}{' '} + + {source.linkText} + .
diff --git a/src/resources/Strings.tsx b/src/resources/Strings.tsx index 2ea3c7db5..4770a9a76 100644 --- a/src/resources/Strings.tsx +++ b/src/resources/Strings.tsx @@ -17,6 +17,16 @@ export const Strings = { linkText: '#perfcompare:mozilla.org on Matrix', href: 'https://matrix.to/#/#perfcompare:mozilla.org', }, + docs: { + text: 'View the docs at', + linkText: 'PerfCompare documentation', + href: 'https://firefox-source-docs.mozilla.org/testing/perfdocs/perfcompare.html', + }, + source: { + text: 'View the source code on', + linkText: 'GitHub', + href: 'https://github.com/mozilla/perfcompare', + }, header: { title: 'PerfCompare', tagline: From 49523ac516d0e8265435e96ae4d3b526b0c9f6b0 Mon Sep 17 00:00:00 2001 From: Alexander Moses Date: Sun, 1 Feb 2026 17:36:44 +0000 Subject: [PATCH 2/3] Bug-1948879: Update snapshots Update snapshots --- .../__snapshots__/OverTimeResultsView.test.tsx.snap | 2 +- .../__snapshots__/ResultsTable.test.tsx.snap | 4 ++-- .../__snapshots__/ResultsView.test.tsx.snap | 2 +- .../__snapshots__/SubtestsResultsView.test.tsx.snap | 10 +++++----- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap index 7903056d6..f3bdc9916 100644 --- a/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap +++ b/src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap @@ -449,7 +449,7 @@ exports[`Results View The table should match snapshot and other elements should role="columnheader" >
- - -
-
-
-
-
- -
-
-
- - -
-
- -
-
-
-
-
-
- -
- - -
-
-
-
-
-
-
-
-
    -
  • - - -
    -
    - try -
    -
    -
    -
    - - - - coconut - - - - - -
    -
    - -
    - johncleese@python.com -
    -
    -
    - -
    - Mar 29, 51, 00:00 UTC -
    -
    -
    -     - - you've got no arms left! - -
    - -
    -
    • -
-
-
-
-
-
- - -
-
- -
-
-
-
-
-
- -
- - -
-
-
-
-
-
-
-
-
    -
  • - - -
    -
    - try -
    -
    -
    -
    - - - - coconut - - - - - -
    -
    - -
    - johncleese@python.com -
    -
    -
    - -
    - Mar 29, 51, 00:00 UTC -
    -
    -
    -     - - you've got no arms left! - -
    - -
    -
    • -
-
-
-
- - -
-
-
- -
-
-
-
-
-
-

- Results -

- -

- Compare with a base -

-
-

-
-
- -
-
-

-
-
-
-
-
-
-
-
-
-
- - -
- -
- -
- -
-
-
-
-
-
-
- - - - -
-
-
-
-
-
- - - - -
-
-
-
-
-
- - - - -
-
-
-
-
- -
-
-
-
-
- -
-
- - Base - -
-
-
- - New - -
-
- -
-
- - - -
-
-
- - -
-
-
- - Total Runs - -
-
-
-
-
-
-
-
-
-
-
-
- - - a11yr - - dhtml.html - - -
- - spam - - - - -
-
-
- - opt - - - e10s - - - fission - - - stylo - - - webrender - -
-
-
-
-
-
- - - Linux 18.04 - -
-
-
- 776.97 ms - -
-
- < -
-
- 791.34 ms - -
-
-
- - Regression -
-
-
- - 1.85 % -
-
- - Medium -
-
- - - B: - - - 1 - - - - - N: - - - 1 - - -
-
-
-
- - - -
-
-
-
- -
-
-
-
-
- -
-
-
-
-
-
- - - macOS 10.15 - -
-
-
- 704.84 ms - -
-
- < -
-
- 712.44 ms - -
-
-
- - Improvement -
-
-
- - 1.08 % -
-
- - Low -
-
- - - B: - - - 1 - - - - - N: - - - 1 - - -
-
-
-
- - - -
-
-
-
- -
-
-
-
-
- -
-
-
-
-
-
- - - Windows 10 - -
-
-
- 643.54 ms - -
-
- > -
-
- 628.09 ms - -
-
-
- - -
-
-
- - -2.4 % -
-
- - High -
-
- - - B: - - - 1 - - - - - N: - - - 1 - - -
-
-
-
- - - -
-
-
-
- -
-
-
-
-
- -
-
-
-
-
-
-
-
-
-
- - - a11yr - - dhtml.html - - -
- - spam - - - - -
-
-
- - opt - -
-
-
-
-
-
- - - Windows 10 - -
-
-
- 643.54 ms - -
-
- > -
-
- 628.09 ms - -
-
-
- - -
-
-
- - -24 % -
-
- - -
-
- - - B: - - - 1 - - - - - N: - - - 1 - - -
-
-
-
- - - -
-
-
-
- -
-
-
-
-
- -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -`; - -exports[`Results Table can load the sort parameters from the URL for a descending sort 1`] = ` - -`; - -exports[`Results Table can load the sort parameters from the URL for an ascending sort 1`] = ` - -`; - -exports[`Results Table can sort the table and persist the sort parameters to the URL 1`] = ` - -`; - -exports[`Results Table can sort the table and persist the sort parameters to the URL 2`] = ` - -`; - -exports[`Results Table can sort the table and persist the sort parameters to the URL 3`] = ` - -`; - -exports[`Results Table can sort the table and persist the sort parameters to the URL 4`] = ` - -`; - -exports[`Results Table can sort the table and persist the sort parameters to the URL 5`] = ` - -`; - -exports[`Results Table for MannWhitneyResultsItem for mann-whitney-u testVersion Should match snapshot 1`] = ` - -
-
-
-
-
-