From fde6186bfe73cbf6df5b79f72c47f45644e0c3e9 Mon Sep 17 00:00:00 2001 From: NRK Date: Thu, 21 May 2026 04:24:48 +0000 Subject: [PATCH 1/2] osc: only clear thumbnails when hiding this currently disables thumbnail even on set_visible(true) calls which was causing flickering due when scrubbing through the timeline. only disable thumbnail when hiding the osc. Fixes: 9ce79bcaa --- player/lua/osc.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/player/lua/osc.lua b/player/lua/osc.lua index d13ca12c391a3..1ee42d0afc172 100644 --- a/player/lua/osc.lua +++ b/player/lua/osc.lua @@ -2708,7 +2708,9 @@ end local function osc_visible(visible) set_bar_visible("osc_visible", visible) - disable_thumbnail() + if not visible then + disable_thumbnail() + end end local function set_wc_visible(visible) From 35e5545eced95a2cc6969521ac7c6abb2b005f64 Mon Sep 17 00:00:00 2001 From: NRK Date: Fri, 22 May 2026 02:37:22 +0000 Subject: [PATCH 2/2] osc: fix thumbnails clearing on visibility change currently hide_bar() bypasses set_visible when visibility was changed to `never`, this can leave the thumbnail hanging. instead of scattering disable_thumbnail() calls around, just call set_visible(false) instead. Fixes: 9ce79bcaa --- player/lua/osc.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/player/lua/osc.lua b/player/lua/osc.lua index 1ee42d0afc172..c348c1046f3c8 100644 --- a/player/lua/osc.lua +++ b/player/lua/osc.lua @@ -2750,9 +2750,9 @@ end local function hide_bar(label, visible_key, anitype_key, set_visible) msg.trace("hide_" .. label) if not state.enabled then + set_visible(false) -- typically hide happens at render() from tick(), but now tick() is -- no-op and won't render again to remove the osc, so do that manually. - state[visible_key] = false render_wipe(state.osd) elseif user_opts.fadeduration > 0 then if state[visible_key] then