Skip to content

[button] Warn in dev mode when rendering a native link #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mj12albert wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[button] Warn in dev mode when rendering a native link #3423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79fd604
Remove link support from useButton
mj12albert Dec 3, 2025
e81b5b4
Revert "Remove link support from useButton"
mj12albert Dec 4, 2025
beb4f7e
Dev warning when rendering a link
mj12albert Dec 4, 2025
74367ec
pnpm dedupe
mj12albert Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react/src/use-button/useButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as React from 'react';
import { isHTMLElement } from '@floating-ui/utils/dom';
import { useStableCallback } from '@base-ui-components/utils/useStableCallback';
import { error } from '@base-ui-components/utils/error';
import { warn } from '@base-ui-components/utils/warn';
import { useIsoLayoutEffect } from '@base-ui-components/utils/useIsoLayoutEffect';
import { makeEventPreventable, mergeProps } from '../merge-props';
import { useCompositeRootContext } from '../composite/root/CompositeRootContext';
Expand Down Expand Up @@ -53,6 +54,10 @@ export function useButton(parameters: useButton.Parameters = {}): useButton.Retu
error(
'A component that acts as a button was rendered as a native <button>, which does not match the default. Ensure that the element passed to the `render` prop of the component is not a real <button>, or set the `nativeButton` prop on the component to `true`.',
);
} else if (elementRef.current.tagName === 'A') {
warn(
Copy link
Member

@LukasTy LukasTy Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT, would error work here as well? 🤔

'A component that acts as a button was rendered as an <a> tag, which could cause usability issues for keyboard and assistive tech users. Prefer using `<a>` directly.',
);
}
}, [isNativeButton]);
}
Expand Down
22 changes: 11 additions & 11 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading