Frequent use of `std::sync::Mutex` in ipstack causes performance issues

[SajjadPourali]

In the ipstack, we frequently use std::sync::Mutex, which can lead to performance degradation due to thread blocking. Ideally, we should replace these with non-blocking synchronization mechanisms to prevent thread contention and improve performance.

[ssrlive]

There is currently no known approach to use a tokio::sync:Mutex in both tcp_main_logic_loop and poll_read at the same time.

But I don't think the performance bottleneck is here.

[SajjadPourali]

There is currently no known approach to use a tokio::sync:Mutex in both tcp_main_logic_loop and poll_read at the same time.

There are some tricks including the following approach, however its implementation in our code is not straightforward.

struct Test {
    d: Arc<Mutex<u8>>,
    b: Option<Pin<Box<dyn Future<Output = ()> + Send>>>,
}

async fn change_value(m: Arc<Mutex<u8>>) {
    let mut guard = m.lock().await;
    *guard = 1;
}

impl AsyncRead for Test {
    fn poll_read(
        mut self: Pin<&mut Self>,
        ctx: &mut Context<'_>,
        _: &mut ReadBuf<'_>,
    ) -> Poll<Result<(), std::io::Error>> {
        let mut fut = self
            .b
            .take()
            .unwrap_or(Box::pin(change_value(self.d.clone())));
        match fut.as_mut().poll(ctx) {
            Poll::Pending => {
                self.b = Some(fut);
                Poll::Pending
            }
            Poll::Ready(_) => Poll::Ready(Ok(())),
        }
    }
}

But I don't think the performance bottleneck is here.

I’m not sure about its impact on performance; we can also run a profiler like pprof-rs to evaluate it.