Skip to content

Bug Report for maximum-sum-circular-subarray #5503

@robert-fekete

Description

@robert-fekete

Bug Report for https://neetcode.io/problems/maximum-sum-circular-subarray

Missing test case:
nums=[5,-3, 1, -2,5]

This solution passes the existing test cases, but it's in fact wrong:

class Solution:
    def maxSubarraySumCircular(self, nums: List[int]) -> int:
        
        n = len(nums)
        arr = nums + nums
        curr = 0
        best = -math.inf

        l = -1
        for i, num in enumerate(arr):
            if i - l > n:
                l += 1
                curr -= arr[l]
                while l + 1< len(arr) and arr[l+1] < 0:
                    l += 1
                    curr -= arr[l]
                    
            curr += num
            if curr > best:
                print((l, i), curr, best)
            best = max(best, curr)
            if curr < 0:
                curr = 0
                l = i

        return best

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions