Work with lines outside class/struct in Clover XML report

[KminekMatej]

Version: 2.5.7

Bug Description

CodeCoverage generator, when specifying Clover XML as output natively does not work with lines outside class / struct definition at project metrics level.

Steps To Reproduce

Run local tests of this project. Tested file tests/CodeCoverage/fixtures.clover/Logger.php has two lines outside the class scope:

$logger = new Logger('php://stdout');  # 1
$logger->log('foo');  # 1

These lines has been tested and reported by xdebug as covered, but statementsCount metric did not count them:

statements: 5
coveredStatements: 3

Expected Behavior

statements: 7
coveredStatements: 5

Possible Solution

PR In the comments

[milo]

I saw this PR request, I'd like to address it, but I'm short on time. Unless someone else does, it'll have to wait.

[KminekMatej]

@milo Understandable, take your time

[KminekMatej]

I switched connected pull request due to inability of rebasing, now check #467 .

I also tried to fix failing checks on this repo, however during solving it discovered probably unsolveable bugs in PHPDBG engine, so two tests are now being skipped when using PHPDBG executor and one test has slightly different expected output when using PHPDBG (mixing stderr with stdout).

Due to dropped support of PHP8.0 in nette/phpstan-rules I also dropped suport here, which could be considered as BC Break

[KminekMatej]

Any chance of reviewal #467 @milo ? Previous MR aged - due to multiple forced pushes was unable to rebase again. I wouldn't like to let this one age as well, since the functionality it brings is pretty marginal and also fixes all checks.

Only thing that (parhaps) needs to be discussed id the dropped support of PHP8.0