fix: improve number input validation and update handling #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
enjeck
force-pushed
the
fix/2154
branch
2 times, most recently
from
299f7ff to
3d19f28
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Member
|
Maybe it is not a regression, but still strikes me awkward: the lower number is inclusive, but the upper limit number is exclusive? Anyway, what I am not sure about is that numbers are changed to either lower or highest value, depending where they are created. I wonder whether this is OK, or whether there should be an error instead. UX question. Screencast_20251204_110805.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2154