fix: global dispatcher

Author: akitaSummer

src/HttpClient.ts

@@ -22,7 +22,6 @@ import {
   request as undiciRequest,
   Dispatcher,
   Agent,
-  getGlobalDispatcher,
   Pool,
 } from 'undici';
 import undiciSymbols from 'undici/lib/core/symbols.js';
@@ -202,12 +201,18 @@ export class HttpClient extends EventEmitter {
       this.#dispatcher = new Agent({
         allowH2: clientOptions.allowH2,
       });
+    } else {
+      this.#dispatcher = new Agent();
     }
     initDiagnosticsChannel();
   }
 
   getDispatcher() {
-    return this.#dispatcher ?? getGlobalDispatcher();
+    // In a multi-version undici scenario
+    // the global dispatcher is the highest version of undici
+    // which will conflict with the maxRedirects field and report an error
+    // so we need to create it who use 5.x version
+    return this.#dispatcher ?? new Agent();
   }
 
   setDispatcher(dispatcher: Dispatcher) {

test/index.test.ts

@@ -229,26 +229,30 @@ describe('index.test.ts', () => {
       let response = await urllib.request(`${_url}foo`, {
         method: 'POST',
         dataType: 'json',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 400);
       assert.deepEqual(response.data, { message: 'mock 400 bad request' });
 
       response = await urllib.request(`${_url}bar?q=1`, {
         method: 'GET',
         dataType: 'json',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 200);
       assert.deepEqual(response.data, { message: 'mock bar with q=1' });
       response = await urllib.request(`${_url}bar?q=2`, {
         method: 'GET',
         dataType: 'json',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 200);
       assert.deepEqual(response.data, { message: 'mock bar with q=2' });
 
       response = await urllib.request(`${_url}download/foo.tgz`, {
         method: 'GET',
         dataType: 'json',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 400);
       assert.deepEqual(response.data, { message: 'mock 400 bad request on tgz' });
@@ -257,6 +261,7 @@ describe('index.test.ts', () => {
       response = await urllib.request(`${_url}download/bar.tgz`, {
         method: 'GET',
         dataType: 'json',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 200);
       assert.equal(response.data.method, 'GET');
@@ -274,6 +279,7 @@ describe('index.test.ts', () => {
       let response = await urllib.request(`${_url}foo.js`, {
         method: 'GET',
         dataType: 'stream',
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 200);
       let bytes = await readableToBytes(response.res);
@@ -283,6 +289,7 @@ describe('index.test.ts', () => {
       response = await urllib.request(`${_url}foo.js`, {
         method: 'GET',
         streaming: true,
+        dispatcher: mockAgent,
       });
       assert.equal(response.status, 200);
       bytes = await readableToBytes(response.res);

test/options.compressed.test.ts

@@ -3,7 +3,7 @@ import { createWriteStream, createReadStream } from 'node:fs';
 import { describe, it, beforeAll, afterAll, beforeEach, afterEach } from 'vitest';
 import urllib from '../src';
 import { startServer } from './fixtures/server';
-import { readableToString, createTempfile, nodeMajorVersion } from './utils';
+import { readableToString, createTempfile } from './utils';
 
 describe('options.compressed.test.ts', () => {
   let close: any;
@@ -193,11 +193,7 @@ describe('options.compressed.test.ts', () => {
       // console.error(err);
       assert.equal(err.name, 'UnzipError');
       assert.equal(err.message, 'Decompression failed');
-      if (nodeMajorVersion() >= 18) {
-        assert.equal(err.code, 'ERR__ERROR_FORMAT_PADDING_1');
-      } else {
-        assert.equal(err.code, 'ERR_PADDING_1');
-      }
+      assert.equal(err.code, 'ERR_PADDING_1');
       assert.equal(err.status, 200);
       assert.equal(err.headers['content-encoding'], 'br');
       return true;