Skip to content

[Change] Code review bug-finding mode and sidecar venv self-scan fix #174

@djm81

Description

@djm81

Summary

Two improvements surfaced from external-repo validation (crewAI, gpt-researcher, and 8 OSS baseline repos):

  1. Code review bug-finding mode — the code review module produces no bug-finding signal on repos that don't use icontract. MISSING_ICONTRACT floods warnings on external repos. CrossHair runs but with a 2s timeout too tight to find counterexamples. No security/bug semgrep rules exist.
  2. Sidecar venv self-scan bug — sidecar installs deps into .specfact/venv, then framework extractors scan the full repo tree including the venv. gpt-researcher reported 25,947 routes (real: 19).

Change

OpenSpec change: openspec/changes/code-review-bug-finding-and-sidecar-venv-fix/

Scope

  • packages/specfact-code-review--bug-hunt flag, CrossHair timeout params, MISSING_ICONTRACT auto-suppression, bugs.yaml semgrep pass
  • packages/specfact-codebase — exclude .specfact/ from all sidecar framework extractor scan paths

Capabilities

  • New: code-review-bug-finding, sidecar-route-extraction
  • Modified: contract-runner, review-run-command

Parent Feature

Part of #175 — [Feature] Code Review External Repo Quality and Bug Finding

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingchange-proposalProposal for a new changecodebaseSpecfact codebase related topicopenspecopenspec change

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions