Update build tools #848
Update build tools #848
Conversation
simonpasquier
commented
Dec 4, 2025
simonpasquier
commented
- Update golangci-lint to v2.7.0.
- Replace faillint by forbidgo (part of golangci-lint).
- Update jsonnet
- Update oapi-codegen
* Update golangci-lint to v2.7.0. * Replace faillint by forbidgo (part of golangci-lint). * Update jsonnet * Update oapi-codegen Signed-off-by: Simon Pasquier <spasquie@redhat.com>
| go 1.24.0 | ||
|
|
||
| require github.com/golangci/golangci-lint/v2 v2.2.2 // cmd/golangci-lint | ||
| toolchain go1.24.10 |
There was a problem hiding this comment.
Can we make it 1.24.6? Internally I don't think we have yet a version higher than that so this would make Logging not being able to build the API image past this PR.
cc @xperimental in case I'm mistaken.
There was a problem hiding this comment.
Yes, 1.24.6 is currently the latest we can use. I am not sure though if having the version in toolchain will produce an error as it would if it was in go, because toolchain is more a "hint of which toolchain to use to build" while go is the "minimum version it's compatible to build with".
I would suggest that we keep toolchain to go1.24.6 just to make things simpler 🙂
There was a problem hiding this comment.
I assume that it's related to https://gitlab.cee.redhat.com/openshift-logging/konflux-log-storage/-/blob/b4098ba6ff9b94d589cbb005531d10e090cd4026/Dockerfile.lokistack-gateway? IIUC it doesn't build the image using make so it shouldn't be impacted. Or am I missing something?
There was a problem hiding this comment.
Ah, I missed that this was a bingo file.
Yes, those are less relevant to the actual build... also bingo seems to mostly ignore the toolchain selection of the main project which makes for interesting errors when mixing different runtime versions across "default install", project requirement and bingo tooling.
I have looked into the new tools feature of Go 1.24 but that one has its drawbacks as well (using the same go.mod is a double-sided sword).
So ... as long as it is not in the go.mod of the project this should be mostly irrelevant for our build. 👍
4 participants
