From ae143371ccb3b3f6d3fcbb4efb502afe53acbdc6 Mon Sep 17 00:00:00 2001
From: mekot-odoo <mekot@odoo.com>
Date: Thu, 12 Feb 2026 10:27:26 +0530
Subject: [PATCH 1/4] [IMP] purchase: add global discount support on RFQ lines

This commit introduces a global discount mechanism that allows users to
apply a percentage or fixed amount discount across all RFQ lines in a
single action, improving usability and efficiency.
---
 purchase_discount/__init__.py                 |  2 ++
 purchase_discount/__manifest__.py             | 16 ++++++++++
 purchase_discount/models/__init__.py          |  1 +
 purchase_discount/models/purchase_order.py    | 15 ++++++++++
 .../security/ir.model.access.csv              |  2 ++
 .../views/purchase_order_view.xml             | 21 ++++++++++++++
 purchase_discount/wizard/__init__.py          |  1 +
 .../wizard/purchase_order_discount.py         | 29 +++++++++++++++++++
 .../wizard/purchase_order_discount.xml        | 26 +++++++++++++++++
 9 files changed, 113 insertions(+)
 create mode 100644 purchase_discount/__init__.py
 create mode 100644 purchase_discount/__manifest__.py
 create mode 100644 purchase_discount/models/__init__.py
 create mode 100644 purchase_discount/models/purchase_order.py
 create mode 100644 purchase_discount/security/ir.model.access.csv
 create mode 100644 purchase_discount/views/purchase_order_view.xml
 create mode 100644 purchase_discount/wizard/__init__.py
 create mode 100644 purchase_discount/wizard/purchase_order_discount.py
 create mode 100644 purchase_discount/wizard/purchase_order_discount.xml

diff --git a/purchase_discount/__init__.py b/purchase_discount/__init__.py
new file mode 100644
index 00000000000..9b4296142f4
--- /dev/null
+++ b/purchase_discount/__init__.py
@@ -0,0 +1,2 @@
+from . import models
+from . import wizard
diff --git a/purchase_discount/__manifest__.py b/purchase_discount/__manifest__.py
new file mode 100644
index 00000000000..48eb7689372
--- /dev/null
+++ b/purchase_discount/__manifest__.py
@@ -0,0 +1,16 @@
+{
+    "name": "purchase discount",
+    "version": "1.0.0",
+    "depends": ["base", "purchase"],
+    "author": "Mehul Kotak",
+    "category": "Task-1",
+    "description": "This perfrom global discount in purchase",
+    "license": "LGPL-3",
+    "application": True,
+    "installable": True,
+    "data": [
+        "security/ir.model.access.csv",
+        "views/purchase_order_view.xml",
+        "wizard/purchase_order_discount.xml",
+    ],
+}
diff --git a/purchase_discount/models/__init__.py b/purchase_discount/models/__init__.py
new file mode 100644
index 00000000000..9f03530643d
--- /dev/null
+++ b/purchase_discount/models/__init__.py
@@ -0,0 +1 @@
+from . import purchase_order
diff --git a/purchase_discount/models/purchase_order.py b/purchase_discount/models/purchase_order.py
new file mode 100644
index 00000000000..9cc21bf6e56
--- /dev/null
+++ b/purchase_discount/models/purchase_order.py
@@ -0,0 +1,15 @@
+from odoo import models
+
+
+class PurchaseOrder(models.Model):
+    _inherit = "purchase.order"
+
+    def action_purchase_global_discount(self):
+        self.ensure_one()
+        return {
+            "name": "Discount",
+            "type": "ir.actions.act_window",
+            "res_model": "purchase.order.discount",
+            "view_mode": "form",
+            "target": "new",
+        }
diff --git a/purchase_discount/security/ir.model.access.csv b/purchase_discount/security/ir.model.access.csv
new file mode 100644
index 00000000000..b02746d58d8
--- /dev/null
+++ b/purchase_discount/security/ir.model.access.csv
@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_purchase_order_discount,access_purchase_order_discount,model_purchase_order_discount,base.group_user,1,1,1,1
diff --git a/purchase_discount/views/purchase_order_view.xml b/purchase_discount/views/purchase_order_view.xml
new file mode 100644
index 00000000000..be7f6e497ff
--- /dev/null
+++ b/purchase_discount/views/purchase_order_view.xml
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+    <record id="view_purchase_order_form" model="ir.ui.view">
+        <field name="name">purchase.order.view.form.discount</field>
+        <field name="model">purchase.order</field>
+        <field name="inherit_id" ref="purchase.purchase_order_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//group[@class='oe_subtotal_footer']" position="before">
+               <group>
+               <group></group>
+                <group>
+                <span style="text-align: center;">
+                    <button name="action_purchase_global_discount"
+                            string="Discount"
+                            type="object"/></group></span>
+               </group>
+            </xpath>
+        </field>
+    </record>
+</odoo>
+
diff --git a/purchase_discount/wizard/__init__.py b/purchase_discount/wizard/__init__.py
new file mode 100644
index 00000000000..510f03e2878
--- /dev/null
+++ b/purchase_discount/wizard/__init__.py
@@ -0,0 +1 @@
+from . import purchase_order_discount
diff --git a/purchase_discount/wizard/purchase_order_discount.py b/purchase_discount/wizard/purchase_order_discount.py
new file mode 100644
index 00000000000..9aa505fcd54
--- /dev/null
+++ b/purchase_discount/wizard/purchase_order_discount.py
@@ -0,0 +1,29 @@
+from odoo import models, fields, api
+
+
+class PurchaseOrderDiscount(models.TransientModel):
+    _name = "purchase.order.discount"
+    _description = "apply global discount on purchase order"
+
+    discount = fields.Float()
+    discount_type = fields.Selection(
+        [("amount", "$"), ("percent", "%")], default="percent"
+    )
+    discount_percent = fields.Float(compute="_calculate_percentage")
+
+    @api.depends("discount", "discount_type")
+    def _calculate_percentage(self):
+        if self.discount_type == "percent":
+            self.discount_percent = self.discount
+        else:
+            order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
+            self.discount_percent = (self.discount * 100) / order.amount_untaxed
+
+    def action_apply_discount(self):
+        order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
+        if self.discount_type == "percent":
+            order.order_line.write({"discount": self.discount})
+        else:
+            order.order_line.write({"discount": 0})
+            self.discount = (self.discount * 100) / order.amount_untaxed
+            order.order_line.write({"discount": self.discount})
diff --git a/purchase_discount/wizard/purchase_order_discount.xml b/purchase_discount/wizard/purchase_order_discount.xml
new file mode 100644
index 00000000000..4e412d98c73
--- /dev/null
+++ b/purchase_discount/wizard/purchase_order_discount.xml
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+
+    <record id="sale_order_line_wizard_form" model="ir.ui.view">
+        <field name="name">purchase.order.discount.form</field>
+        <field name="model">purchase.order.discount</field>
+        <field name="arch" type="xml">
+            <form>
+                <field name="discount"/>
+                <field name="discount_type" nolabel="True"/>
+                <span class="text-muted">
+    (
+                    <field name="discount_percent" nolabel="1"/>
+%
+    )
+                </span>
+
+                <footer>
+                    <button name="action_apply_discount" string="Apply" type="object" class="btn btn-primary"/>
+                    <button special="cancel" string="Discard" class="btn btn-secondary" data-hotkey="x"/>
+                </footer>
+            </form>
+        </field>
+    </record>
+
+</odoo>

From d9622282b7aec1b901e0a12a2ec68b7803a87d5f Mon Sep 17 00:00:00 2001
From: mekot-odoo <mekot@odoo.com>
Date: Thu, 12 Feb 2026 11:53:44 +0530
Subject: [PATCH 2/4] [FIX] purchase: avoid ZeroDivisionError in discount
 wizard

Prevented division by zero when converting a fixed discount
to percentage if the RFQ untaxed amount is zero.
---
 purchase_discount/wizard/purchase_order_discount.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/purchase_discount/wizard/purchase_order_discount.py b/purchase_discount/wizard/purchase_order_discount.py
index 9aa505fcd54..acf35fb6e70 100644
--- a/purchase_discount/wizard/purchase_order_discount.py
+++ b/purchase_discount/wizard/purchase_order_discount.py
@@ -1,4 +1,5 @@
 from odoo import models, fields, api
+from odoo.exceptions import UserError
 
 
 class PurchaseOrderDiscount(models.TransientModel):
@@ -13,17 +14,23 @@ class PurchaseOrderDiscount(models.TransientModel):
 
     @api.depends("discount", "discount_type")
     def _calculate_percentage(self):
+        order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
         if self.discount_type == "percent":
             self.discount_percent = self.discount
-        else:
-            order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
+        elif order.amount_untaxed != 0:
             self.discount_percent = (self.discount * 100) / order.amount_untaxed
+        else:
+            self.discount_percent = 0
 
     def action_apply_discount(self):
         order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
         if self.discount_type == "percent":
             order.order_line.write({"discount": self.discount})
-        else:
+        elif order.amount_untaxed != 0:
             order.order_line.write({"discount": 0})
             self.discount = (self.discount * 100) / order.amount_untaxed
             order.order_line.write({"discount": self.discount})
+        else:
+            raise UserError(
+                ("Cannot apply fixed discount because Total Amount is already zero.")
+            )

From 92609ab33455b17267ee1fefd4ad6c202833efaf Mon Sep 17 00:00:00 2001
From: mekot-odoo <mekot@odoo.com>
Date: Fri, 13 Feb 2026 11:06:41 +0530
Subject: [PATCH 3/4] [IMP] purchase: improve position of global discount
 button on RFQ form

Adjusted the placement of the Discount button in the purchase order
form view to align it to the right side for better visibility and
usability when applying global discounts.
---
 purchase_discount/views/purchase_order_view.xml     | 13 ++++---------
 purchase_discount/wizard/purchase_order_discount.py |  2 +-
 .../wizard/purchase_order_discount.xml              |  1 -
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/purchase_discount/views/purchase_order_view.xml b/purchase_discount/views/purchase_order_view.xml
index be7f6e497ff..08aa404d4df 100644
--- a/purchase_discount/views/purchase_order_view.xml
+++ b/purchase_discount/views/purchase_order_view.xml
@@ -5,15 +5,10 @@
         <field name="model">purchase.order</field>
         <field name="inherit_id" ref="purchase.purchase_order_form"/>
         <field name="arch" type="xml">
-            <xpath expr="//group[@class='oe_subtotal_footer']" position="before">
-               <group>
-               <group></group>
-                <group>
-                <span style="text-align: center;">
-                    <button name="action_purchase_global_discount"
-                            string="Discount"
-                            type="object"/></group></span>
-               </group>
+            <xpath expr="//field[@name='order_line']" position="after">
+                <div class="d-flex justify-content-end mt-2 mb-2">
+                    <button string="Discount" name="action_purchase_global_discount" type="object" class="btn btn-secondary"/>
+                </div>
             </xpath>
         </field>
     </record>
diff --git a/purchase_discount/wizard/purchase_order_discount.py b/purchase_discount/wizard/purchase_order_discount.py
index acf35fb6e70..c1485cc5eb8 100644
--- a/purchase_discount/wizard/purchase_order_discount.py
+++ b/purchase_discount/wizard/purchase_order_discount.py
@@ -32,5 +32,5 @@ def action_apply_discount(self):
             order.order_line.write({"discount": self.discount})
         else:
             raise UserError(
-                ("Cannot apply fixed discount because Total Amount is already zero.")
+                "Cannot apply fixed discount because Total Amount is already zero."
             )
diff --git a/purchase_discount/wizard/purchase_order_discount.xml b/purchase_discount/wizard/purchase_order_discount.xml
index 4e412d98c73..30ba4e29d90 100644
--- a/purchase_discount/wizard/purchase_order_discount.xml
+++ b/purchase_discount/wizard/purchase_order_discount.xml
@@ -14,7 +14,6 @@
 %
     )
                 </span>
-
                 <footer>
                     <button name="action_apply_discount" string="Apply" type="object" class="btn btn-primary"/>
                     <button special="cancel" string="Discard" class="btn btn-secondary" data-hotkey="x"/>

From dfd1dc2f03cf06a01a950a9ae2730382d1e0705a Mon Sep 17 00:00:00 2001
From: mekot-odoo <mekot@odoo.com>
Date: Tue, 17 Feb 2026 19:02:04 +0530
Subject: [PATCH 4/4] [FIX] purchase: correct global discount computation

Compute the discount using the sum of (price_unit * quantity) instead of
amount_untaxed to avoid inconsistent results when updating discounts.

Add a constraint to restrict the discount percentage between 0 and 100
and properly initialize the base amount to prevent UnboundLocalError.
---
 purchase_discount/__init__.py                 |  1 -
 purchase_discount/__manifest__.py             |  4 +-
 purchase_discount/models/__init__.py          |  1 -
 purchase_discount/models/purchase_order.py    | 15 ------
 .../security/ir.model.access.csv              |  2 +-
 .../views/purchase_order_view.xml             |  2 +-
 .../wizard/purchase_order_discount.py         | 53 +++++++++++++------
 .../wizard/purchase_order_discount.xml        | 15 ++++--
 8 files changed, 53 insertions(+), 40 deletions(-)
 delete mode 100644 purchase_discount/models/__init__.py
 delete mode 100644 purchase_discount/models/purchase_order.py

diff --git a/purchase_discount/__init__.py b/purchase_discount/__init__.py
index 9b4296142f4..40272379f72 100644
--- a/purchase_discount/__init__.py
+++ b/purchase_discount/__init__.py
@@ -1,2 +1 @@
-from . import models
 from . import wizard
diff --git a/purchase_discount/__manifest__.py b/purchase_discount/__manifest__.py
index 48eb7689372..32523119b93 100644
--- a/purchase_discount/__manifest__.py
+++ b/purchase_discount/__manifest__.py
@@ -6,11 +6,11 @@
     "category": "Task-1",
     "description": "This perfrom global discount in purchase",
     "license": "LGPL-3",
-    "application": True,
+    "auto_install": True,
     "installable": True,
     "data": [
         "security/ir.model.access.csv",
-        "views/purchase_order_view.xml",
         "wizard/purchase_order_discount.xml",
+        "views/purchase_order_view.xml",
     ],
 }
diff --git a/purchase_discount/models/__init__.py b/purchase_discount/models/__init__.py
deleted file mode 100644
index 9f03530643d..00000000000
--- a/purchase_discount/models/__init__.py
+++ /dev/null
@@ -1 +0,0 @@
-from . import purchase_order
diff --git a/purchase_discount/models/purchase_order.py b/purchase_discount/models/purchase_order.py
deleted file mode 100644
index 9cc21bf6e56..00000000000
--- a/purchase_discount/models/purchase_order.py
+++ /dev/null
@@ -1,15 +0,0 @@
-from odoo import models
-
-
-class PurchaseOrder(models.Model):
-    _inherit = "purchase.order"
-
-    def action_purchase_global_discount(self):
-        self.ensure_one()
-        return {
-            "name": "Discount",
-            "type": "ir.actions.act_window",
-            "res_model": "purchase.order.discount",
-            "view_mode": "form",
-            "target": "new",
-        }
diff --git a/purchase_discount/security/ir.model.access.csv b/purchase_discount/security/ir.model.access.csv
index b02746d58d8..d27226be896 100644
--- a/purchase_discount/security/ir.model.access.csv
+++ b/purchase_discount/security/ir.model.access.csv
@@ -1,2 +1,2 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_purchase_order_discount,access_purchase_order_discount,model_purchase_order_discount,base.group_user,1,1,1,1
+access_purchase_order_discount,access_purchase_order_discount,model_purchase_order_discount,purchase.group_purchase_user,1,1,1,1
diff --git a/purchase_discount/views/purchase_order_view.xml b/purchase_discount/views/purchase_order_view.xml
index 08aa404d4df..394760b6713 100644
--- a/purchase_discount/views/purchase_order_view.xml
+++ b/purchase_discount/views/purchase_order_view.xml
@@ -7,7 +7,7 @@
         <field name="arch" type="xml">
             <xpath expr="//field[@name='order_line']" position="after">
                 <div class="d-flex justify-content-end mt-2 mb-2">
-                    <button string="Discount" name="action_purchase_global_discount" type="object" class="btn btn-secondary"/>
+                    <button string="Discount" name="%(purchase_discount.action_purchase_order_discount)d" type="action" class="btn btn-secondary"/>
                 </div>
             </xpath>
         </field>
diff --git a/purchase_discount/wizard/purchase_order_discount.py b/purchase_discount/wizard/purchase_order_discount.py
index c1485cc5eb8..b1004088273 100644
--- a/purchase_discount/wizard/purchase_order_discount.py
+++ b/purchase_discount/wizard/purchase_order_discount.py
@@ -1,36 +1,59 @@
 from odoo import models, fields, api
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
 
 
 class PurchaseOrderDiscount(models.TransientModel):
     _name = "purchase.order.discount"
-    _description = "apply global discount on purchase order"
+    _description = "Apply Global Discount on Purchase Order"
 
-    discount = fields.Float()
+    discount = fields.Float(string="Discount", required=True)
     discount_type = fields.Selection(
-        [("amount", "$"), ("percent", "%")], default="percent"
+        [("amount", "$"), ("percent", "%")], default="percent", string="Discount Type"
     )
-    discount_percent = fields.Float(compute="_calculate_percentage")
+    discount_percent = fields.Float(
+        compute="_calculate_percentage", string="Calculated Percentage"
+    )
+
+    @api.constrains("discount", "discount_type")
+    def _check_discount_limit(self):
+        if self.discount < 0 or self.discount > 100:
+            raise ValidationError("Discount value is invalid")
+
+    def _get_base_untaxed_amount(self, order):
+        total = 0.0
+        for line in order.order_line:
+            total += line.price_unit * line.product_qty
+            return total
 
     @api.depends("discount", "discount_type")
     def _calculate_percentage(self):
         order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
+        base_amount = self._get_base_untaxed_amount(order)
         if self.discount_type == "percent":
             self.discount_percent = self.discount
-        elif order.amount_untaxed != 0:
-            self.discount_percent = (self.discount * 100) / order.amount_untaxed
+        elif base_amount > 0:
+            self.discount_percent = (self.discount * 100) / base_amount
         else:
             self.discount_percent = 0
 
     def action_apply_discount(self):
+        self.ensure_one()
         order = self.env["purchase.order"].browse(self.env.context.get("active_id"))
+
+        if not order.order_line:
+            raise UserError("There are no lines on this order to discount.")
+
+        base_amount = self._get_base_untaxed_amount(order)
+
         if self.discount_type == "percent":
-            order.order_line.write({"discount": self.discount})
-        elif order.amount_untaxed != 0:
-            order.order_line.write({"discount": 0})
-            self.discount = (self.discount * 100) / order.amount_untaxed
-            order.order_line.write({"discount": self.discount})
+            target_discount = self.discount
         else:
-            raise UserError(
-                "Cannot apply fixed discount because Total Amount is already zero."
-            )
+            if base_amount <= 0:
+                raise UserError("Cannot apply an amount discount to a $0 order.")
+            target_discount = (self.discount * 100) / base_amount
+
+        # Final check to ensure calculated amount doesn't exceed 100%
+        if target_discount > 100:
+            raise UserError("The discount amount exceeds the total value of the order.")
+
+        order.order_line.write({"discount": target_discount})
diff --git a/purchase_discount/wizard/purchase_order_discount.xml b/purchase_discount/wizard/purchase_order_discount.xml
index 30ba4e29d90..4f5df9839ee 100644
--- a/purchase_discount/wizard/purchase_order_discount.xml
+++ b/purchase_discount/wizard/purchase_order_discount.xml
@@ -1,16 +1,23 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <odoo>
 
-    <record id="sale_order_line_wizard_form" model="ir.ui.view">
+    <record id="action_purchase_order_discount" model="ir.actions.act_window">
+        <field name="name">Discount</field>
+        <field name="res_model">purchase.order.discount</field>
+        <field name="view_mode">form</field>
+        <field name="target">new</field>
+    </record>
+
+    <record id="purchase_order_line_wizard_form" model="ir.ui.view">
         <field name="name">purchase.order.discount.form</field>
         <field name="model">purchase.order.discount</field>
         <field name="arch" type="xml">
             <form>
                 <field name="discount"/>
-                <field name="discount_type" nolabel="True"/>
-                <span class="text-muted">
+                <field name="discount_type" nolabel="True" class=/>
+<span class="text-muted">
     (
-                    <field name="discount_percent" nolabel="1"/>
+                    <field name="discount_percent" nolabel="1" invisible="discount_type =='percent'"/>
 %
     )
                 </span>